[Koha-patches] [PATCH] Bug 11756 - Hold ratios report sorting incorrectly

Owen Leonard oleonard at myacpl.org
Fri Feb 14 15:02:06 CET 2014


The DataTables plugin doesn't by default take multiple columns into
account when sorting. The hold ratios report presents a situation where
it makes sense to sort by default based on two columns: hold count and
title, since there are likely to be many titles with the same hold
count.

This patch adds sorting by default on holds (descending) and title
(ascending). It also modifies the configuration of the title sort to
exclude articles when sorting.

To test, view the hold ratios report. If necessary use the filter form
to reduce the minimum hold ratio and generate more results. Confirm that
the correct columns can be sorted.

Note that by default one can manually trigger sorting on two columns by
shift-clicking the second column header.
---
 .../prog/en/modules/circ/reserveratios.tt          |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
index d55382e..2cc539a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
@@ -17,9 +17,21 @@
             function () { $(this).toggleClass("ulined") }
         );
         $("#holdst").dataTable($.extend(true, {}, dataTablesDefaults, {
+            "aaSorting": [ [0,'desc'], [3,'asc'] ],
             "aoColumnDefs": [
                 { "aTargets": [ 8 ], "sType": "natural" }
             ],
+            "aoColumns": [
+                null,
+                null,
+                null,
+                { "sType": "anti-the" },
+                null,
+                null,
+                null,
+                null,
+                null
+            ],
             "aLengthMenu": [[10, 20, 50, 100, -1], [10, 20, 50, 100, "All"]],
             "iDisplayLength": 20,
             "sPaginationType": "four_button"
-- 
1.7.9.5


More information about the Koha-patches mailing list