[Koha-patches] [PATCH] bug 11537: Increasing test coverage for C4::Log

David Cook dcook at prosentient.com.au
Tue Jan 14 00:12:44 CET 2014


From: alex_h <dhorsman at xtra.co.nz>

To test:
1. run prove t/Log.t
   Notice 1 test is run
2. apply patch
3. run prove t/Log.t
   Notice 3 tests are run

Signed-off-by: David Cook <dcook at prosentient.com.au>

Works as described.

I think there might be a typo in "Testing git log status". Should
this read "Testing get log status"? (Noticed while looking at the
code/running perl t/Log.t.)

In any case, thanks for the patch. Looks good!
---
 t/Log.t |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/t/Log.t b/t/Log.t
index eca6b9c..20b96a9 100755
--- a/t/Log.t
+++ b/t/Log.t
@@ -6,9 +6,12 @@
 use strict;
 use warnings;
 
-use Test::More tests => 1;
+use Test::More tests => 3;
 
 BEGIN {
         use_ok('C4::Log');
 }
 
+ok( my $hash=GetLogStatus(),"Testing git log status");
+
+ok( $hash->{BorrowersLog}, 'Testing hash is non empty');
-- 
1.7.7.4




More information about the Koha-patches mailing list