[Koha-patches] [PATCH] Bug 7817 - Items Permanent location (shelving location) is set to NULL when item is edited

David Cook dcook at prosentient.com.au
Thu Jun 19 05:33:02 CEST 2014


From: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

A quick fix to prevent more damages.
No perceived side-effects so far.

Signed-off-by: David Cook <dcook at prosentient.com.au>

This is actually a perfectly good fix for this issue. I've changed
the explanatory comment to explain why.

Another option would be to remove the 'exists' check in the sub
_do_column_fixes_for_mod(), but this is just as functional.
---
 C4/Items.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/C4/Items.pm b/C4/Items.pm
index c183644..9db89e3 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -459,7 +459,7 @@ my %default_values_for_mod_from_marc = (
     itemnotes            => undef, 
     itype                => undef, 
     location             => undef, 
-    permanent_location   => undef,
+#    permanent_location   => undef, # "undef" counts as "exists" which disrupts proper handling of location and permanent_location in _do_column_fixes_for_mod()
     materials            => undef, 
     notforloan           => 0,
     paidfor              => undef, 
-- 
1.7.7.4




More information about the Koha-patches mailing list