From oleonard at myacpl.org Fri May 2 20:37:05 2014 From: oleonard at myacpl.org (Owen Leonard) Date: Fri, 2 May 2014 14:37:05 -0400 Subject: [Koha-patches] [PATCH] Bug 12106 - Capitalization: Patron Attributes on tools/patron import Message-ID: <1399055825-27958-1-git-send-email-oleonard@myacpl.org> There are three instances of incorrectly-capitalized "Patron Attributes" on the patron import page. This patch corrects them. To test, view the patron import page (Tools -> Import patrons). Confirm that instances of the phrase "patron attributes" in the bottom-most fieldset are correctly capitalized. --- .../prog/en/modules/tools/import_borrowers.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt index 1ed23d0..894dc2a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt @@ -131,12 +131,12 @@ [% IF ( ExtendedPatronAttributes ) %]
- Patron Attributes + Patron attributes
  1. - +
  2. - +
-- 1.7.9.5 From oleonard at myacpl.org Mon May 5 21:33:11 2014 From: oleonard at myacpl.org (Owen Leonard) Date: Mon, 5 May 2014 15:33:11 -0400 Subject: [Koha-patches] [PATCH] Bug 12147 [Alternate] Column width for action links on invoices too small Message-ID: <1399318391-7192-1-git-send-email-oleonard@myacpl.org> This alternative patch groups "action" links into a menu as was done with Bug 11763. This patch also converts the date column sorting configuration to use header class instead of an index. This patch also corrects a couple of HTML markup errors: An improperly-closed and an improperly closed "}else{c=0;for(d=e.length;c'+e[c]+""}b+="";e=t.createElement("div");if(!a.aanFeatures.l)e.id=a.sTableId+"_length";e.className=a.oClasses.sLength;e.innerHTML="";i('select option[value="'+a._iDisplayLength+'"]',e).attr("selected",true);i("select",e).bind("change.DT",function(){var f=i(this).val(),g=a.aanFeatures.l;c=0;for(d=g.length;ca.aiDisplay.length||a._iDisplayLength==-1?a.aiDisplay.length:a._iDisplayStart+a._iDisplayLength}function Qa(a){if(a.oScroll.bInfinite)return null; -var b=t.createElement("div");b.className=a.oClasses.sPaging+a.sPaginationType;l.ext.oPagination[a.sPaginationType].fnInit(a,b,function(c){J(c);H(c)});a.aanFeatures.p||a.aoDrawCallback.push({fn:function(c){l.ext.oPagination[c.sPaginationType].fnUpdate(c,function(d){J(d);H(d)})},sName:"pagination"});return b}function Da(a,b){var c=a._iDisplayStart;if(typeof b==="number"){a._iDisplayStart=b*a._iDisplayLength;if(a._iDisplayStart>a.fnRecordsDisplay())a._iDisplayStart=0}else if(b=="first")a._iDisplayStart= -0;else if(b=="previous"){a._iDisplayStart=a._iDisplayLength>=0?a._iDisplayStart-a._iDisplayLength:0;if(a._iDisplayStart<0)a._iDisplayStart=0}else if(b=="next")if(a._iDisplayLength>=0){if(a._iDisplayStart+a._iDisplayLength=0){b=parseInt((a.fnRecordsDisplay()-1)/a._iDisplayLength,10)+1;a._iDisplayStart=(b-1)*a._iDisplayLength}else a._iDisplayStart=0;else M(a,0,"Unknown paging action: "+ -b);i(a.oInstance).trigger("page",a);return c!=a._iDisplayStart}function Na(a){var b=t.createElement("div");if(!a.aanFeatures.r)b.id=a.sTableId+"_processing";b.innerHTML=a.oLanguage.sProcessing;b.className=a.oClasses.sProcessing;a.nTable.parentNode.insertBefore(b,a.nTable);return b}function O(a,b){if(a.oFeatures.bProcessing)for(var c=a.aanFeatures.r,d=0,e=c.length;d0){d=d[0];if(d._captionSide==="top")j.appendChild(d);else d._captionSide==="bottom"&&y&&m.appendChild(d)}if(a.oScroll.sX!==""){c.style.width=s(a.oScroll.sX);e.style.width=s(a.oScroll.sX);if(y!==null)f.style.width=s(a.oScroll.sX);i(e).scroll(function(){c.scrollLeft=this.scrollLeft;if(y!==null)f.scrollLeft=this.scrollLeft})}if(a.oScroll.sY!== -"")e.style.height=s(a.oScroll.sY);a.aoDrawCallback.push({fn:Xa,sName:"scrolling"});a.oScroll.bInfinite&&i(e).scroll(function(){if(!a.bDrawing&&i(this).scrollTop()!==0)if(i(this).scrollTop()+i(this).height()>i(a.nTable).height()-a.oScroll.iLoadGap)if(a.fnDisplayEnd()d.offsetHeight||i(d).css("overflow-y")=="scroll"))a.nTable.style.width=s(i(a.nTable).outerWidth()-a.oScroll.iBarWidth)}else if(a.oScroll.sXInner!=="")a.nTable.style.width=s(a.oScroll.sXInner); -else if(e==i(d).width()&&i(d).height()e-a.oScroll.iBarWidth)a.nTable.style.width=s(e)}else a.nTable.style.width=s(e);e=i(a.nTable).outerWidth();f=a.nTHead.getElementsByTagName("tr");g=g.getElementsByTagName("tr");V(function(I,Q){k=I.style;k.paddingTop="0";k.paddingBottom="0";k.borderTopWidth="0";k.borderBottomWidth="0";k.height=0;u=i(I).width();Q.style.width=s(u);w.push(u)},g,f);i(g).height(0);if(a.nTFoot!== -null){j=m.getElementsByTagName("tr");m=a.nTFoot.getElementsByTagName("tr");V(function(I,Q){k=I.style;k.paddingTop="0";k.paddingBottom="0";k.borderTopWidth="0";k.borderBottomWidth="0";k.height=0;u=i(I).width();Q.style.width=s(u);w.push(u)},j,m);i(j).height(0)}V(function(I){I.innerHTML="";I.style.width=s(w.shift())},g);a.nTFoot!==null&&V(function(I){I.innerHTML="";I.style.width=s(w.shift())},j);if(i(a.nTable).outerWidth()d.offsetHeight||i(d).css("overflow-y")=="scroll"?e+a.oScroll.iBarWidth: -e;if(B&&(d.scrollHeight>d.offsetHeight||i(d).css("overflow-y")=="scroll"))a.nTable.style.width=s(j-a.oScroll.iBarWidth);d.style.width=s(j);b.parentNode.style.width=s(j);if(a.nTFoot!==null)z.parentNode.style.width=s(j);if(a.oScroll.sX==="")M(a,1,"The table cannot fit into the current element which will cause column misalignment. The table has been drawn at its minimum possible width.");else a.oScroll.sXInner!==""&&M(a,1,"The table cannot fit into the current element which will cause column misalignment. Increase the sScrollXInner value or remove it to allow automatic calculation")}else{d.style.width= -s("100%");b.parentNode.style.width=s("100%");if(a.nTFoot!==null)z.parentNode.style.width=s("100%")}if(a.oScroll.sY==="")if(B)d.style.height=s(a.nTable.offsetHeight+a.oScroll.iBarWidth);if(a.oScroll.sY!==""&&a.oScroll.bCollapse){d.style.height=s(a.oScroll.sY);B=a.oScroll.sX!==""&&a.nTable.offsetWidth>d.offsetWidth?a.oScroll.iBarWidth:0;if(a.nTable.offsetHeight -d.clientHeight||i(d).css("overflow-y")=="scroll";b.style.paddingRight=c?a.oScroll.iBarWidth+"px":"0px";if(a.nTFoot!==null){Y.style.width=s(B);z.style.width=s(B);z.style.paddingRight=c?a.oScroll.iBarWidth+"px":"0px"}i(d).scroll();if(a.bSorted||a.bFiltered)d.scrollTop=0}function V(a,b,c){for(var d=0,e=b.length;dtd",b);g=W(a,f);for(f=d=0;f0)a.aoColumns[f].sWidth=s(c);d++}e=i(b).css("width");a.nTable.style.width=e.indexOf("%")!==-1?e:s(i(b).outerWidth());b.parentNode.removeChild(b)}if(j)a.nTable.style.width=s(j)}function $a(a,b){if(a.oScroll.sX===""&&a.oScroll.sY!==""){i(b).width();b.style.width=s(i(b).outerWidth()-a.oScroll.iBarWidth)}else if(a.oScroll.sX!=="")b.style.width=s(i(b).outerWidth())}function Za(a,b){var c=ab(a,b);if(c<0)return null; -if(a.aoData[c].nTr===null){var d=t.createElement("td");d.innerHTML=E(a,c,b,"");return d}return T(a,c)[b]}function ab(a,b){for(var c=-1,d=-1,e=0;e/g,"");if(f.length>c){c=f.length;d=e}}return d}function s(a){if(a===null)return"0px";if(typeof a=="number"){if(a<0)return"0px";return a+"px"}var b=a.charCodeAt(a.length-1);if(b<48||b>57)return a;return a+"px"}function bb(){var a=t.createElement("p"),b=a.style;b.width="100%";b.height="200px"; -b.padding="0px";var c=t.createElement("div");b=c.style;b.position="absolute";b.top="0px";b.left="0px";b.visibility="hidden";b.width="200px";b.height="150px";b.padding="0px";b.overflow="hidden";c.appendChild(a);t.body.appendChild(c);b=a.offsetWidth;c.style.overflow="scroll";a=a.offsetWidth;if(b==a)a=c.clientWidth;t.body.removeChild(c);return b-a}function X(a,b){var c,d,e,f,g,j,m=[],k=[],y=l.ext.oSort,u=a.aoData,w=a.aoColumns,z=a.oLanguage.oAria;if(!a.oFeatures.bServerSide&&(a.aaSorting.length!==0|| -a.aaSortingFixed!==null)){m=a.aaSortingFixed!==null?a.aaSortingFixed.concat(a.aaSorting):a.aaSorting.slice();for(c=0;c/g,"");b=w[c].nTh;b.removeAttribute("aria-sort");b.removeAttribute("aria-label");if(w[c].bSortable)if(m.length>0&&m[0][0]==c){b.setAttribute("aria-sort",m[0][1]=="asc"?"ascending":"descending");b.setAttribute("aria-label",e+((w[c].asSorting[m[0][2]+1]?w[c].asSorting[m[0][2]+1]:w[c].asSorting[0])=="asc"?z.sSortAscending:z.sSortDescending))}else b.setAttribute("aria-label",e+(w[c].asSorting[0]=="asc"?z.sSortAscending:z.sSortDescending)); -else b.setAttribute("aria-label",e)}a.bSorted=true;i(a.oInstance).trigger("sort",a);if(a.oFeatures.bFilter)U(a,a.oPreviousSearch,1);else{a.aiDisplay=a.aiDisplayMaster.slice();a._iDisplayStart=0;J(a);H(a)}}function ua(a,b,c,d){db(b,{},function(e){if(a.aoColumns[c].bSortable!==false){var f=function(){var g,j;if(e.shiftKey){for(var m=false,k=0;k=g)for(b=0;b4096){a=t.cookie.split(";");for(var j=0,m=a.length;j=0;f--)e.push(b[f].fn.apply(a.oInstance,d));c!==null&&i(a.oInstance).trigger(c,d);return e}function hb(a){return function(){var b=[A(this[l.ext.iApiIndex])].concat(Array.prototype.slice.call(arguments));return l.ext.oApi[a].apply(this,b)}}var ib=ha.JSON?JSON.stringify:function(a){var b=typeof a;if(b!=="object"||a===null){if(b==="string")a='"'+a+'"';return a+""}var c,d,e=[],f=i.isArray(a);for(c in a){d=a[c];b=typeof d;if(b==="string")d= -'"'+d+'"';else if(b==="object"&&d!==null)d=ib(d);e.push((f?"":'"'+c+'":')+d)}return(f?"[":"{")+e+(f?"]":"}")};this.$=function(a,b){var c,d=[],e=A(this[l.ext.iApiIndex]);b||(b={});b=i.extend({},{filter:"none",order:"current",page:"all"},b);if(b.page=="current"){b=e._iDisplayStart;for(c=e.fnDisplayEnd();b=d.aiDisplay.length){d._iDisplayStart-=d._iDisplayLength;if(d._iDisplayStart<0)d._iDisplayStart=0}if(c===p||c){J(d);H(d)}return g};this.fnDestroy=function(a){var b=A(this[l.ext.iApiIndex]),c=b.nTableWrapper.parentNode,d=b.nTBody,e,f;a=a===p?false:true;b.bDestroying= -true;L(b,"aoDestroyCallback","destroy",[b]);e=0;for(f=b.aoColumns.length;etr>td."+b.oClasses.sRowEmpty,b.nTable).parent().remove();if(b.nTable!=b.nTHead.parentNode){i(b.nTable).children("thead").remove();b.nTable.appendChild(b.nTHead)}if(b.nTFoot&&b.nTable!=b.nTFoot.parentNode){i(b.nTable).children("tfoot").remove();b.nTable.appendChild(b.nTFoot)}b.nTable.parentNode.removeChild(b.nTable); -i(b.nTableWrapper).remove();b.aaSorting=[];b.aaSortingFixed=[];aa(b);i(ca(b)).removeClass(b.asStripeClasses.join(" "));i("th, td",b.nTHead).removeClass([b.oClasses.sSortable,b.oClasses.sSortableAsc,b.oClasses.sSortableDesc,b.oClasses.sSortableNone].join(" "));if(b.bJUI){i("th span."+b.oClasses.sSortIcon+", td span."+b.oClasses.sSortIcon,b.nTHead).remove();i("th, td",b.nTHead).each(function(){var g=i("div."+b.oClasses.sSortJUIWrapper,this),j=g.contents();i(this).append(j);g.remove()})}if(!a&&b.nTableReinsertBefore)c.insertBefore(b.nTable, -b.nTableReinsertBefore);else a||c.appendChild(b.nTable);e=0;for(f=b.aoData.length;e=C(d);if(!k)for(e=a;et<"F"ip>'}else i.extend(g.oClasses,l.ext.oStdClasses); -i(this).addClass(g.oClasses.sTable);if(g.oScroll.sX!==""||g.oScroll.sY!=="")g.oScroll.iBarWidth=bb();if(g.iInitDisplayStart===p){g.iInitDisplayStart=h.iDisplayStart;g._iDisplayStart=h.iDisplayStart}if(h.bStateSave){g.oFeatures.bStateSave=true;eb(g,h);K(g,"aoDrawCallback",Ea,"state_save")}if(h.iDeferLoading!==null){g.bDeferLoading=true;a=i.isArray(h.iDeferLoading);g._iRecordsDisplay=a?h.iDeferLoading[0]:h.iDeferLoading;g._iRecordsTotal=a?h.iDeferLoading[1]:h.iDeferLoading}if(h.aaData!==null)f=true; -if(h.oLanguage.sUrl!==""){g.oLanguage.sUrl=h.oLanguage.sUrl;i.getJSON(g.oLanguage.sUrl,null,function(m){Ca(m);i.extend(true,g.oLanguage,h.oLanguage,m);oa(g)});e=true}else i.extend(true,g.oLanguage,h.oLanguage);if(h.asStripeClasses===null)g.asStripeClasses=[g.oClasses.sStripeOdd,g.oClasses.sStripeEven];c=false;d=i(this).children("tbody").children("tr");a=0;for(b=g.asStripeClasses.length;a=g.aoColumns.length)g.aaSorting[a][0]=0;var j=g.aoColumns[g.aaSorting[a][0]];if(g.aaSorting[a][2]===p)g.aaSorting[a][2]=0;if(h.aaSorting===p&&g.saved_aaSorting===p)g.aaSorting[a][1]=j.asSorting[0];c=0;for(d=j.asSorting.length;c< -d;c++)if(g.aaSorting[a][1]==j.asSorting[c]){g.aaSorting[a][2]=c;break}}aa(g);a=i(this).children("caption").each(function(){this._captionSide=i(this).css("caption-side")});b=i(this).children("thead");if(b.length===0){b=[t.createElement("thead")];this.appendChild(b[0])}g.nTHead=b[0];b=i(this).children("tbody");if(b.length===0){b=[t.createElement("tbody")];this.appendChild(b[0])}g.nTBody=b[0];g.nTBody.setAttribute("role","alert");g.nTBody.setAttribute("aria-live","polite");g.nTBody.setAttribute("aria-relevant", -"all");b=i(this).children("tfoot");if(b.length===0&&a.length>0&&(g.oScroll.sX!==""||g.oScroll.sY!=="")){b=[t.createElement("tfoot")];this.appendChild(b[0])}if(b.length>0){g.nTFoot=b[0];da(g.aoFooter,g.nTFoot)}if(f)for(a=0;a=parseInt(v,10)};l.fnIsDataTable=function(h){for(var n=l.settings,q=0;q'+o.sPrevious+''+o.sNext+"": -'';i(n).append(o);var x=i("a",n);o=x[0];x=x[1];h.oApi._fnBindAction(o,{action:"previous"},v);h.oApi._fnBindAction(x,{action:"next"},v);if(!h.aanFeatures.p){n.id=h.sTableId+"_paginate";o.id=h.sTableId+"_previous";x.id=h.sTableId+ -"_next";o.setAttribute("aria-controls",h.sTableId);x.setAttribute("aria-controls",h.sTableId)}},fnUpdate:function(h){if(h.aanFeatures.p)for(var n=h.oClasses,q=h.aanFeatures.p,o=0,v=q.length;o'+o.sFirst+''+o.sPrevious+''+o.sNext+''+o.sLast+"");var C=i("a",n);o=C[0];v=C[1];var D=C[2]; -C=C[3];h.oApi._fnBindAction(o,{action:"first"},x);h.oApi._fnBindAction(v,{action:"previous"},x);h.oApi._fnBindAction(D,{action:"next"},x);h.oApi._fnBindAction(C,{action:"last"},x);if(!h.aanFeatures.p){n.id=h.sTableId+"_paginate";o.id=h.sTableId+"_first";v.id=h.sTableId+"_previous";D.id=h.sTableId+"_next";C.id=h.sTableId+"_last"}},fnUpdate:function(h,n){if(h.aanFeatures.p){var q=l.ext.oPagination.iFullNumbersShowPages,o=Math.floor(q/2),v=Math.ceil(h.fnRecordsDisplay()/h._iDisplayLength),x=Math.ceil(h._iDisplayStart/ -h._iDisplayLength)+1,C="",D,G=h.oClasses,F,S=h.aanFeatures.p,P=function(ja){h.oApi._fnBindAction(this,{page:ja+D-1},function(N){h.oApi._fnPageChange(h,N.data.page);n(h);N.preventDefault()})};if(h._iDisplayLength===-1)x=o=D=1;else if(v=v-o){D=v-q+1;o=v}else{D=x-Math.ceil(q/2)+1;o=D+q-1}for(q=D;q<=o;q++)C+=x!==q?''+h.fnFormatNumber(q)+"":''+h.fnFormatNumber(q)+"";q=0;for(o=S.length;qn?1:0},"string-desc":function(h,n){return hn?-1:0},"html-pre":function(h){return h.replace(/<.*?>/g,"").toLowerCase()},"html-asc":function(h,n){return hn?1:0},"html-desc":function(h,n){return hn?-1:0},"date-pre":function(h){h=Date.parse(h);if(isNaN(h)||h==="")h=Date.parse("01/01/1970 00:00:00");return h},"date-asc":function(h, -n){return h-n},"date-desc":function(h,n){return n-h},"numeric-pre":function(h){return h=="-"||h===""?0:h*1},"numeric-asc":function(h,n){return h-n},"numeric-desc":function(h,n){return n-h}});i.extend(l.ext.aTypes,[function(h){if(typeof h==="number")return"numeric";else if(typeof h!=="string")return null;var n,q=false;n=h.charAt(0);if("0123456789-".indexOf(n)==-1)return null;for(var o=1;o")!=-1)return"html";return null}]);i.fn.DataTable=l;i.fn.dataTable=l;i.fn.dataTableSettings=l.settings;i.fn.dataTableExt=l.ext})(jQuery,window,document,undefined); -- 1.7.9.5 From oleonard at myacpl.org Tue May 6 18:56:52 2014 From: oleonard at myacpl.org (Owen Leonard) Date: Tue, 6 May 2014 12:56:52 -0400 Subject: [Koha-patches] [PATCH] Bug 12199 - Move textarea-expander and tablednd jQuery plugins outside of language-specific directory Message-ID: <1399395412-12290-1-git-send-email-oleonard@myacpl.org> This patch moves the textarea-expander and tablednd jQuery plugins to intranet-tmpl/prog/lib/jquery/plugins so that they will not be duplicated for each set of translated templates. To test you must have the SearchEngine system preference set to 'Solr.' Apply the patch and test Solr search engine configuration in Administration -> Search engine configuration. Textarea resizing should work correctly. Table row reordering should work correctly. --- .../lib/jquery/plugins/jquery.textarea-expander.js | 0 .../{prog/en => }/lib/jquery/plugins/tablednd.js | 0 .../en/modules/admin/searchengine/solr/indexes.tt | 4 ++-- 3 files changed, 2 insertions(+), 2 deletions(-) rename koha-tmpl/intranet-tmpl/{prog/en => }/lib/jquery/plugins/jquery.textarea-expander.js (100%) rename koha-tmpl/intranet-tmpl/{prog/en => }/lib/jquery/plugins/tablednd.js (100%) diff --git a/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.textarea-expander.js b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.textarea-expander.js similarity index 100% rename from koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.textarea-expander.js rename to koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.textarea-expander.js diff --git a/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/tablednd.js b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/tablednd.js similarity index 100% rename from koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/tablednd.js rename to koha-tmpl/intranet-tmpl/lib/jquery/plugins/tablednd.js diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt index b72a1ea..1f7c35b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt @@ -1,8 +1,8 @@ [% INCLUDE 'doc-head-open.inc' %] Koha › Administration › Solr config [% INCLUDE 'doc-head-close.inc' %] - - + + \ No newline at end of file diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt index 7dc5b81..8e2b25b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt @@ -8,16 +8,7 @@ [% END %] - +[% INCLUDE 'slip-print.inc' #printThenClose %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt index eee5aef..4c71072 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt @@ -1,15 +1,11 @@ +[% USE Koha %] [% USE KohaDates %] [% INCLUDE 'doc-head-open.inc' %] Summary for [% firstname %] [% surname %] ([% cardnumber %]) - +[% INCLUDE 'slip-print.inc' #printThenClose %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt index 80d3dc0..c7d67a1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt @@ -1,15 +1,11 @@ +[% USE Koha %] [% INCLUDE 'doc-head-open.inc' %] Print Receipt for [% cardnumber %] - +[% INCLUDE 'slip-print.inc' #printThenClose %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt index 26be3f4..64bbf35 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt @@ -1,14 +1,10 @@ +[% USE Koha %] [% INCLUDE 'doc-head-open.inc' %] Print Receipt for [% cardnumber %] - +[% INCLUDE 'slip-print.inc' #printThenClose %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt index 8a19918..29e64da 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt @@ -1,14 +1,10 @@ +[% USE Koha %] [% INCLUDE 'doc-head-open.inc' %] Print Receipt for [% cardnumber %] - +[% INCLUDE 'slip-print.inc' #printThenClose %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt index 224c916..8ad25ac 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt @@ -23,7 +23,7 @@ -- 1.7.7.4 From oleonard at myacpl.org Thu May 22 15:28:37 2014 From: oleonard at myacpl.org (Owen Leonard) Date: Thu, 22 May 2014 09:28:37 -0400 Subject: [Koha-patches] [PATCH] Bug 12308 - show all title subfields on the holds list Message-ID: <1400765317-23516-1-git-send-email-oleonard@myacpl.org> The patron summary page in the bootstrap OPAC does not show subtitle in the list of checkouts, overdues, or holds. This patch corrects this. To test, set your OPAC theme to bootstrap and log in to the OPAC as a user who has items checked out, items overdue, and items on hold. At least one of each of those should be a title which has a subtitle as defined in Administration -> Keyword to MARC mapping. Subtitles should appear correctly under the "Checked out," "Overdue," and "Holds" tabs. --- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index 50c66c1..797e671 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -184,7 +184,8 @@ [% END # / IF JacketImages %] - [% ISSUE.title |html %] [% ISSUE.author %] + [% ISSUE.title |html %] [% FOREACH subtitl IN ISSUE.subtitle %] [% subtitl.subfield %][% END %] + [% ISSUE.author %] [% IF ( ISSUE.overdue ) %] @@ -338,7 +339,7 @@ [% WAITIN.itemtype %] - [% WAITIN.waiting_title %] + [% WAITIN.waiting_title %] [% FOREACH subtitl IN WAITIN.subtitle %] [% subtitl.subfield %][% END %] [% WAITIN.author %] @@ -422,7 +423,7 @@ [% END # /IF jacketcell %] - [% OVERDUE.title |html %] + [% OVERDUE.title |html %] [% FOREACH subtitl IN OVERDUE.subtitle %] [% subtitl.subfield %][% END %] [% OVERDUE.author %] @@ -520,7 +521,7 @@ [% END %] - [% RESERVE.reserves_title %] + [% RESERVE.reserves_title %] [% FOREACH subtitl IN RESERVE.subtitle %] [% subtitl.subfield %][% END %] [% RESERVE.author %] -- 1.7.9.5 From oleonard at myacpl.org Thu May 22 16:03:29 2014 From: oleonard at myacpl.org (Owen Leonard) Date: Thu, 22 May 2014 10:03:29 -0400 Subject: [Koha-patches] [PATCH] Bug 12309 - Add more fields to batch patron modification tool Message-ID: <1400767409-24926-1-git-send-email-oleonard@myacpl.org> It would be helpful to be able to use the batch patron modification tool to update city, state, zipcode, and country. This patch adds this functionality. This patch corrects an error in the batch modification script which would have incorrectly marked first name as required if surname was required. This patch also converts the table sorting configuration to use table header class names instead of index-based sorting for columns containing dates. To test, apply the patch and submit a batch of patrons to the batch patron modification tool (Tools -> Batch patron modification). In the list of patrons which will be modified you should see columns for city, state, zipcode, and country. Table sorting should work correctly without errors, including the registration and expiry date columns. In the list of fields which can be batch modified you should see inputs for city, state zipcode, and country. These fields should correctly reflect mandatory/not mandatory based on the BorrowerMandatoryField system preference. Submit batch changes to a variety of fields and confirm that changes are applied correctly. On the page of results the table should correctly show all fields and be sorted correctly. --- .../prog/en/modules/tools/modborrowers.tt | 28 +++++++++++++----- tools/modborrowers.pl | 31 ++++++++++++++++++-- 2 files changed, 49 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt index dfb2107..b4f4c52 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ -14,15 +14,13 @@ $("#borrowerst").dataTable($.extend(true, {}, dataTablesDefaults, { "sDom": 't', [% IF ( op == 'show_results' ) %] - "aoColumns": [ - null,null,null,null,null,{ "sType": "title-string" },{ "sType": "title-string" }[% FOREACH attrh IN attributes_header %],null[% END %] + "aoColumnDefs": [ + { 'sType': "title-string", 'aTargets' : [ 'title-string'] } ], [% ELSE %] "aoColumnDefs": [ { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false }, - ], - "aoColumns": [ - null,null,null,null,null,null,{ "sType": "title-string" },{ "sType": "title-string" }[% FOREACH attrh IN attributes_header %],null[% END %] + { 'sType': "title-string", 'aTargets' : [ 'title-string'] } ], [% END %] "bPaginate": false @@ -232,8 +230,12 @@ First name Library Category - Registration date - Expiry date + City + State + Zip code + Country + Registration date + Expiry date [% FOREACH attrh IN attributes_header %] [% attrh.attribute %] [% END %] @@ -250,6 +252,10 @@ [% borrower.firstname %] [% borrower.branchname %] [% borrower.categorycode %] + [% borrower.city %] + [% borrower.state %] + [% borrower.zipcode %] + [% borrower.country %] [% borrower.dateenrolled | $KohaDates %] [% borrower.dateexpiry | $KohaDates %] [% FOREACH pa IN borrower.patron_attributes %] @@ -288,6 +294,14 @@ Library: [% CASE 'categorycode' %] Category + [% CASE 'city' %] + City + [% CASE 'state' %] + State + [% CASE 'zipcode' %] + Zip code + [% CASE 'country' %] + Country [% CASE 'sort1' %] Sort 1: [% CASE 'sort2' %] diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl index 5bd2103..3b7808b 100755 --- a/tools/modborrowers.pl +++ b/tools/modborrowers.pl @@ -21,7 +21,8 @@ # # Batch Edit Patrons # Modification for patron's fields: -# surname firstname branchcode categorycode sort1 sort2 dateenrolled dateexpiry borrowernotes +# surname firstname branchcode categorycode city state zipcode country sort1 +# sort2 dateenrolled dateexpiry borrowernotes # And for patron attributes. use Modern::Perl; @@ -169,7 +170,7 @@ if ( $op eq 'show' ) { { name => "firstname", type => "text", - mandatory => ( grep /surname/, @mandatoryFields ) ? 1 : 0, + mandatory => ( grep /firstname/, @mandatoryFields ) ? 1 : 0, } , { @@ -187,6 +188,30 @@ if ( $op eq 'show' ) { } , { + name => "city", + type => "text", + mandatory => ( grep /city/, @mandatoryFields ) ? 1 : 0, + } + , + { + name => "state", + type => "text", + mandatory => ( grep /state/, @mandatoryFields ) ? 1 : 0, + } + , + { + name => "zipcode", + type => "text", + mandatory => ( grep /zipcode/, @mandatoryFields ) ? 1 : 0, + } + , + { + name => "country", + type => "text", + mandatory => ( grep /country/, @mandatoryFields ) ? 1 : 0, + } + , + { name => "sort1", type => @sort1_option ? "select" : "text", option => \@sort1_option, @@ -230,7 +255,7 @@ if ( $op eq 'do' ) { my @disabled = $input->param('disable_input'); my $infos; - for my $field ( qw/surname firstname branchcode categorycode sort1 sort2 dateenrolled dateexpiry borrowernotes/ ) { + for my $field ( qw/surname firstname branchcode categorycode city state zipcode country sort1 sort2 dateenrolled dateexpiry borrowernotes/ ) { my $value = $input->param($field); $infos->{$field} = $value if $value; $infos->{$field} = "" if grep { /^$field$/ } @disabled; -- 1.7.9.5 From oleonard at myacpl.org Thu May 22 19:24:59 2014 From: oleonard at myacpl.org (Owen Leonard) Date: Thu, 22 May 2014 13:24:59 -0400 Subject: [Koha-patches] [PATCH] Bug 12255 - Amazon cover images have useless image alt text in bootstrap Message-ID: <1400779499-27157-1-git-send-email-oleonard@myacpl.org> "item-thumbnail" is not a useful alt text for an Amazon book cover image. Better would be the link's title text, "View on Amazon.com." This patch makes this correction. (Rather than "View at Amazon.com" which doesn't sound correct to me). To test you must have the OPACAmazonCoverImages system preference enabled. Log in to the OPAC and view your list of checked-out titles. The alt text for cover images should be "View on Amazon.com." Test in both prog and Bootstrap. --- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 ++-- koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index 50c66c1..8e4110b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -151,7 +151,7 @@ [% IF ( OPACAmazonCoverImages ) %] [% IF ( ISSUE.normalized_isbn ) %] - item-thumbnail + View on Amazon.com [% ELSE %] No cover image available [% END %] @@ -389,7 +389,7 @@ [% IF ( OPACAmazonCoverImages ) %] [% IF ( OVERDUE.normalized_isbn ) %] - + View on Amazon.com [% ELSE %] No cover image available [% END %] diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt index c3a4fe1..9f1478e 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt @@ -193,7 +193,7 @@ var MSG_CONFIRM_RESUME_HOLDS = _("Are you sure you want to resume all suspended [% IF ( JacketImages ) %] -[% IF ( OPACAmazonCoverImages ) %][% IF ( ISSUE.normalized_isbn ) %]Cover Image[% ELSE %]No cover image available[% END %][% END %] +[% IF ( OPACAmazonCoverImages ) %][% IF ( ISSUE.normalized_isbn ) %]View on Amazon.com[% ELSE %]No cover image available[% END %][% END %] [% IF ( GoogleJackets ) %][% IF ( ISSUE.normalized_isbn ) %]
[% ELSE %]No cover image available[% END %][% END %] @@ -348,7 +348,7 @@ var MSG_CONFIRM_RESUME_HOLDS = _("Are you sure you want to resume all suspended [% IF ( JacketImages ) %] -[% IF ( OPACAmazonCoverImages ) %][% IF ( OVERDUE.normalized_isbn ) %][% ELSE %]No cover image available[% END %][% END %] +[% IF ( OPACAmazonCoverImages ) %][% IF ( OVERDUE.normalized_isbn ) %]View on Amazon.com[% ELSE %]No cover image available[% END %][% END %] [% IF ( GoogleJackets ) %][% IF ( OVERDUE.normalized_isbn ) %]
[% ELSE %]No cover image available[% END %][% END %] -- 1.7.9.5 From oleonard at myacpl.org Thu May 22 19:28:49 2014 From: oleonard at myacpl.org (Owen Leonard) Date: Thu, 22 May 2014 13:28:49 -0400 Subject: [Koha-patches] [PATCH] Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC Message-ID: <1400779730-27497-1-git-send-email-oleonard@myacpl.org> If you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. This patch corrects the problem. This patch also adds a missing [% USE AuthorisedValues %] which would cause errors if the template tried to display a custom suggestion status as defined in the SUGGEST_STATUS authorized value category. To test, accept or reject a suggestion and specify a custom reason. View that suggestion in the Bootstrap OPAC and confirm that the custom reason is displayed. --- .../bootstrap/en/modules/opac-suggestions.tt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt index 573cd37..f58dd00 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt @@ -1,4 +1,5 @@ [% USE Koha %] +[% USE AuthorisedValues %] [% INCLUDE 'doc-head-open.inc' %][% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › [% IF ( op_add ) %]Enter a new purchase suggestion[% END %] [% IF ( op_else ) %]Purchase Suggestions[% END %] @@ -205,6 +206,7 @@ [% ELSIF ( suggestions_loo.REJECTED ) %]Suggestion declined [% ELSIF ( suggestions_loo.AVAILABLE ) %]Available in the library [% ELSE %] [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS, 1 ) %] [% END %] + [% IF ( suggestions_loo.reason ) %]([% suggestions_loo.reason |html %])[% END %] [% END # / FOREACH suggestions_loo %] -- 1.7.9.5 From Viktor.Sarge at regionhalland.se Fri May 30 12:14:27 2014 From: Viktor.Sarge at regionhalland.se (Viktor.Sarge at regionhalland.se) Date: Fri, 30 May 2014 10:14:27 +0000 Subject: [Koha-patches] Introduction from Viktor Message-ID: Dear subscribers of the patches list! My name is Viktor Sarge and I am now extending my lurking about from IRC, the general list and the dev list to the patches list. I work as a senior regional library development officer at the regional library of Halland in Sweden. I?ve been involved with Koha for a few years now and presently run a project trying to do as much as possible to make Koha a relevant free infrastructure for Swedish libraries. This includes both funding development in Koha and helping interested libraries get hold of the right information. The reason I subscribe to this list is that I want to learn more about the inner workings of Koha and plan to submit one or two line patches once in a while if I can wrap my head around using git to format my changes correctly. I?m not really a programmer but am dusting of my old SQL and learning a bit of Perl to be able to better understand what?s going on. Kind regards! /Viktor Sarge Viktor Sarge Regionbibliotek Halland Kultur i Halland TFN: 0046(0)35-17 98 73 E-POST: Viktor.Sarge at regionhalland.se BES?KSADRESS: S?dra v?gen 9, 30180 Halmstad WEBB: www.regionhalland.se/regionbibliotek From nengard at bywatersolutions.com Sat May 31 19:33:44 2014 From: nengard at bywatersolutions.com (Nicole C. Engard) Date: Sat, 31 May 2014 12:33:44 -0500 Subject: [Koha-patches] [PATCH] [BUG 11958] Fix typon in classification source help The Classification Sources help file said the source was in the 942$2 but it's in the 952$2 and 94$2 so this patch fixes that. Message-ID: <1401557624-6775-1-git-send-email-nengard@bywatersolutions.com> To test: * Go to Admin > Classification Sources * Click Help * Confirm the Help file is right now --- .../prog/en/modules/help/admin/classsources.tt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/classsources.tt index b33b947..da49580 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/classsources.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/classsources.tt @@ -2,7 +2,7 @@

Classification Sources

-

Source of classification or shelving scheme is an Authorized Values category that is mapped to field 942$2 in Koha's MARC Bibliographic frameworks.

+

Source of classification or shelving scheme is an Authorized Values category that is mapped to field 952$2 and 942$2 in Koha's MARC Bibliographic frameworks.

Commonly used values of this field are:

-- 1.7.2.3 From nengard at bywatersolutions.com Sat May 31 19:34:30 2014 From: nengard at bywatersolutions.com (Nicole C. Engard) Date: Sat, 31 May 2014 12:34:30 -0500 Subject: [Koha-patches] [PATCH] [BUG 12231] Update AllowMultipleIssuesOnABiblio language Message-ID: <1401557670-6811-1-git-send-email-nengard@bywatersolutions.com> This preference had misleading language, this patch changes it a bit to make it clearer. To test: * Apply patch * Visit System Preferences * Go to Circulation Tab * Read description of AllowMultipleIssuesOnABiblio preference * Confirm that it is clearer --- .../en/modules/admin/preferences/circulation.pref | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index 81065f9..5a768a6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -348,7 +348,7 @@ Circulation: choices: yes: Allow no: "Don't allow" - - patrons to check out multiple items from the same record, except for records with subscriptions. + - "patrons to check out multiple items from the same record. (NOTE: This will only effect records without a subscription attached.)" Checkin Policy: - - pref: BlockReturnOfWithdrawnItems -- 1.7.2.3