[Koha-patches] [PATCH 2/2] Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm
Indranil Das Gupta
idgbpo at gmail.com
Thu May 14 03:05:55 CEST 2015
From: Aleisha <aleishaamohia at hotmail.com>
This patch sets $term to be an empty string.
Test plan
=========
1/ enable 'UseCourseReserves' syspref in Circulation preferences
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go to the opac, click on 'Course reserve' tab to go to
opac-course-reserves.pl
4/ notice the warning - "opac-course-reserves.pl: Use of uninitialized
value $term" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-course-reserves.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error
Remarks: Testing result match expected test plan output. The QA tests
pass with "OK" for the commit.
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
---
C4/CourseReserves.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm
index 4a7bb22..7e160d0 100644
--- a/C4/CourseReserves.pm
+++ b/C4/CourseReserves.pm
@@ -1052,6 +1052,7 @@ sub SearchCourses {
GROUP BY c.course_id
";
+ $term //= '';
$term = "%$term%";
@params = ($term) x 10;
--
1.9.1
More information about the Koha-patches
mailing list