[Koha-patches] [PATCH] Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric"

Srdjan srdjan at catalyst.net.nz
Thu Jul 7 05:27:40 CEST 2016


From: Marc Véron <veron at veron.ch>

To vrify:
- Go to Home > Administration > Patron attribute types
- Make sure you have some patron attribute types with no branches limitation
- For each attribute type you get a warning in intranet-error.log:
patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284.

To test:
- Appy patch
- Verify that warnings no longer appear in intranet-error.log

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
index 3ee2fc5..580f38d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
@@ -267,7 +267,7 @@ $(document).ready(function() {
             <td>[% item.code |html %]</td>
             <td>[% item.description %]</td>
             <td>
-                [% IF item.branches.size > 0 %]
+                [% IF ( item.branches.size && item.branches.size > 0 ) %]
                     [% branches_str = "" %]
                     [% FOREACH branch IN item.branches %]
                         [% branches_str = branches_str _ " " _ branch.branchname _ "(" _ branch.branchcode _ ")" %]
-- 
2.7.4


More information about the Koha-patches mailing list