[Koha-patches] [PATCH] Bug 15006 Correct indentation of EXPORTs in Sip.pm
Srdjan
srdjan at catalyst.net.nz
Wed Jul 13 02:58:32 CEST 2016
From: Colin Campbell <colin.campbell at ptfs-europe.com>
Removed tabs and used spaces consistently
Used 'use base' to remove unnecessary BEGIN sub and
explicit setting of ISA at application level
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
C4/SIP/Sip.pm | 31 +++++++++++++------------------
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm
index ec549e6..15bb9a3 100644
--- a/C4/SIP/Sip.pm
+++ b/C4/SIP/Sip.pm
@@ -16,24 +16,19 @@ use IO::Handle;
use C4::SIP::Sip::Constants qw(SIP_DATETIME FID_SCREEN_MSG);
use C4::SIP::Sip::Checksum qw(checksum);
-use vars qw(@ISA @EXPORT_OK %EXPORT_TAGS);
-
-BEGIN {
- @ISA = qw(Exporter);
-
- @EXPORT_OK = qw(y_or_n timestamp add_field maybe_add add_count
- denied sipbool boolspace write_msg get_timeout
- $error_detection $protocol_version $field_delimiter
- $last_response);
-
- %EXPORT_TAGS = (
- all => [qw(y_or_n timestamp add_field maybe_add
- add_count denied sipbool boolspace write_msg
- get_timeout
- $error_detection $protocol_version
- $field_delimiter $last_response)]);
-}
-
+use base qw(Exporter);
+
+our @EXPORT_OK = qw(y_or_n timestamp add_field maybe_add add_count
+ denied sipbool boolspace write_msg get_timeout
+ $error_detection $protocol_version $field_delimiter
+ $last_response);
+
+our %EXPORT_TAGS = (
+ all => [qw(y_or_n timestamp add_field maybe_add
+ add_count denied sipbool boolspace write_msg
+ get_timeout
+ $error_detection $protocol_version
+ $field_delimiter $last_response)]);
our $error_detection = 0;
our $protocol_version = 1;
--
2.7.4
More information about the Koha-patches
mailing list