[Koha-patches] [PATCH] Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons

Srdjan srdjan at catalyst.net.nz
Mon May 16 08:08:54 CEST 2016


From: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Simple patch for a silly error, this single line is going to fix a
critical bug.
If a patron attribute is limited to a library, all the values for that attributes
for every patrons will be deleted.

Test plan:
Create a patron attribute limited to a library
Set the the attribute for a patron
Set the the attribute for another patron
=> Without this patch applied, the attribute's value for the first
patron is deleted
=> With this patch applied, the 2 values exist in the DB after the
second edition

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 C4/Members/Attributes.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm
index 1036e58..b269532 100644
--- a/C4/Members/Attributes.pm
+++ b/C4/Members/Attributes.pm
@@ -254,7 +254,7 @@ sub DeleteBorrowerAttributes {
     $query .= $branch_limit
         ? q{
             LEFT JOIN borrower_attribute_types_branches ON bat_code = code
-            WHERE b_branchcode = ? OR b_branchcode IS NULL
+            WHERE ( b_branchcode = ? OR b_branchcode IS NULL )
                 AND borrowernumber = ?
         }
         : q{
-- 
2.7.4


More information about the Koha-patches mailing list