From dpavlin at rot13.org  Mon Sep 18 17:39:00 2017
From: dpavlin at rot13.org (Dobrica Pavlinusic)
Date: Mon, 18 Sep 2017 17:39:00 +0200
Subject: [Koha-patches] [PATCH] Bug 19332 - Basket grouping PDF and CSV
	exports empty
Message-ID: <1505749140-6342-1-git-send-email-dpavlin@rot13.org>

This bug was introduced in commit 2bf3ce268de6bc8b2386cfb5d768f60b05d75f44
Bug 17196: [QA Follow-up] Additional fix on acqui/basketgroup
---
 acqui/basketgroup.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
index e1a16fd..0e8a9a1 100755
--- a/acqui/basketgroup.pl
+++ b/acqui/basketgroup.pl
@@ -184,7 +184,7 @@ sub printbasketgrouppdf{
             # Editor Number
             my $en;
             my $edition;
-            my $ord->{marcxml} = C4::Biblio::GetXmlBiblio( $ord->{biblionumber} );
+            $ord->{marcxml} = C4::Biblio::GetXmlBiblio( $ord->{biblionumber} );
             my $marcrecord=eval{MARC::Record::new_from_xml( $ord->{marcxml},'UTF-8' )};
             if ($marcrecord){
                 if ( C4::Context->preference("marcflavour") eq 'UNIMARC' ) {
-- 
2.1.4


From dpavlin at rot13.org  Mon Sep 18 19:20:49 2017
From: dpavlin at rot13.org (Dobrica Pavlinusic)
Date: Mon, 18 Sep 2017 19:20:49 +0200
Subject: [Koha-patches] [PATCH] Bug 19334 - circulation history doesn't set
	biblionumber so left navigation is broken
Message-ID: <1505755249-22500-1-git-send-email-dpavlin@rot13.org>

Navigation on the left (Normal, MARC, etc...) needs biblionumber in
template variables to work.

Test:
1. go to checkout history for any biblio
2. verify that normal, MARC, etc links on the left no longer work
   due to missing biblionumber in URL
3. apply patch and test it again
---
 catalogue/issuehistory.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/catalogue/issuehistory.pl b/catalogue/issuehistory.pl
index 070a128..d154a21 100755
--- a/catalogue/issuehistory.pl
+++ b/catalogue/issuehistory.pl
@@ -50,6 +50,7 @@ my $issues = GetBiblioIssues($biblionumber);
 my $biblio = Koha::Biblios->find( $biblionumber );
 
 $template->param(
+    biblionumber => $biblionumber, # required for left-side navigation
     biblio       => $biblio,
     total        => scalar @$issues,
     issues       => $issues,
-- 
2.1.4


From dpavlin at rot13.org  Wed Sep 20 17:30:55 2017
From: dpavlin at rot13.org (Dobrica Pavlinusic)
Date: Wed, 20 Sep 2017 17:30:55 +0200
Subject: [Koha-patches] [PATCH] Bug 19350 - Holds without link in 773
	trigger SQL::Abstract::puke
Message-ID: <1505921455-14199-1-git-send-email-dpavlin@rot13.org>

Test:
1. find bibio without items which has something in field 773
   (for us, it's article) but doesn't have 0 or 9 (host item entry)
2. click on hold in left menu
3. verify application error
4. apply patch and verify that it works
---
 C4/Items.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/C4/Items.pm b/C4/Items.pm
index 0b6a77e..b64aa60 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -1341,7 +1341,12 @@ sub get_hostitemnumbers_of {
 
     foreach my $hostfield ( $marcrecord->field($tag) ) {
         my $hostbiblionumber = $hostfield->subfield($biblio_s);
+        next unless $hostbiblionumber; # have tag, don't have $biblio_s subfield
         my $linkeditemnumber = $hostfield->subfield($item_s);
+        if ( ! $linkeditemnumber ) {
+            warn "ERROR biblionumber $biblionumber has 773^0, but doesn't have 9";
+            next;
+        }
         my $is_from_biblio = Koha::Items->search({ itemnumber => $linkeditemnumber, biblionumber => $hostbiblionumber });
         push @returnhostitemnumbers, $linkeditemnumber
           if $is_from_biblio;
-- 
2.1.4