[Koha-patches] [PATCH] Bug 19350 - Holds without link in 773 trigger SQL::Abstract::puke
Dobrica Pavlinusic
dpavlin at rot13.org
Wed Sep 20 17:30:55 CEST 2017
Test:
1. find bibio without items which has something in field 773
(for us, it's article) but doesn't have 0 or 9 (host item entry)
2. click on hold in left menu
3. verify application error
4. apply patch and verify that it works
---
C4/Items.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/C4/Items.pm b/C4/Items.pm
index 0b6a77e..b64aa60 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -1341,7 +1341,12 @@ sub get_hostitemnumbers_of {
foreach my $hostfield ( $marcrecord->field($tag) ) {
my $hostbiblionumber = $hostfield->subfield($biblio_s);
+ next unless $hostbiblionumber; # have tag, don't have $biblio_s subfield
my $linkeditemnumber = $hostfield->subfield($item_s);
+ if ( ! $linkeditemnumber ) {
+ warn "ERROR biblionumber $biblionumber has 773^0, but doesn't have 9";
+ next;
+ }
my $is_from_biblio = Koha::Items->search({ itemnumber => $linkeditemnumber, biblionumber => $hostbiblionumber });
push @returnhostitemnumbers, $linkeditemnumber
if $is_from_biblio;
--
2.1.4
More information about the Koha-patches
mailing list