[Koha-win32] Re: [Koha] Error log
Carol Ku
carolcool01 at yahoo.com
Tue Apr 4 22:20:54 CEST 2006
Stephen:
Not sure you have the same problem I encountered. If so, download the file attached by Rob Weir, that shall fix the problem.
Koha window users keep having the problem with editing MARC subfield. I wonder if this bug will be fixed in later versions. I was helped by Rob Weir in fixing the problem. But I guess the bug is still there.
Rob Weir <robweir at alum.drexel.edu> wrote:
Hi Carol:
I'm sorry. I didn't realize you were still having a problem. I thought you probably edited the file and made the change I suggested below. If you install a simple editor that shows you what line you are on (I can suggest a couple freeware editors if you want), you can just make the change yourself and see if it fixes the problem.
I was able to duplicate your problem once and when I made the change below, it went away. But then I changed it back and could no longer duplicate the problem. So I am not sure it will work.
If you don't want to edit the file yourself, I have attached a copy of the changed file to this email. Save it to C:\usr\koha224\intranet\cgi-bin\koha\admin and replace the file that is there now. Then test to see if that fixes your problem.
Please let me know if it works or not. If it doesn't work, please send me the last few lines of your intranet-error_log.
Rob
Carol Ku wrote: Hi Rob:
Do you think this issue will be fixed in the next release of v.3?
We just recently installed Windows 2.2.4, if this function of eiditing MARC subfield will not be available in the near future, we will seriously consider investing time and financial resources to re-install Koha on Linux. But if this problem can be fixed in version 3 release, we can wait. Thanks.
Carol
Rob Weir <robweir at alum.drexel.edu> wrote:
Chris:
On the windows install, the value_builder folder is at $intranetdir\cgi-bin\koha\value_builder. I think that should be the same as on a non-windows install.
I can duplicate Carol's problem. If I change line 140 in marc_subfields_structure.pl from
my $cgidir = C4::Context->intranetdir ."/cgi-bin";
to
! my $cgidir = C4::Context->intranetdir ."/cgi-bin/koha";
it fixes the probelm.
Is this a bug in marc_subfields_structure.pl or is this something specific to file locations on a windows install?
Rob
Carol Ku wrote:
This error log may be cleaner. Encountered this message when I try to edit subfield under tag 100 Personal Name
---------------------------------
---------------------------------
[Tue Nov 08 17:07:42 2005] [error] [client 127.0.0.1] Premature end of script headers: marc_subfields_structure.pl, referer: http://intranet/cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=100&frameworkcode= [! Tue Nov 08 17:07:42 2005] [error] [client 127.0.0.1] can't opendir c:\\usr\\koha224\\intranet/value_builder: No such file or directory at C:/usr/koha224/intranet/cgi-bin/koha/admin/marc_subfields_structure.pl line 143., referer: http://intranet/cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=100&frameworkcode=
---------------------------------
Yahoo! Music Unlimited - Access over 1 million songs. Try it free. #!/usr/bin/perl
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
use strict;
use C4::Output;
use C4::Interface::CGI::Output;
use C4::Auth;
use CGI;
use C4::Search;
use C4::Context;
use HTML::Template;
sub StringSearch {
my ($env,$searchstring,$frameworkcode)=@_;
my $dbh = C4::Context->dbh;
$searchstring=~ s/\'/\\\'/g;
my @data=split(' ',$searchstring);
my $count=@data;
my $sth=$dbh->prepare("Select * from marc_subfield_structure where (tagfield like ? and frameworkcode=?) order by tagfield");
$sth->execute("$searchstring%",$frameworkcode);
my @results;
my $cnt=0;
my $u=1;
while (my $data=$sth->fetchrow_hashref){
push(@results,$data);
$cnt ++;
$u++;
}
$sth->finish;
$dbh->disconnect;
return ($cnt,\@results);
}
my $input = new CGI;
my $tagfield=$input->param('tagfield');
my $tagsubfield=$input->param('tagsubfield');
my $frameworkcode=$input->param('frameworkcode');
my $pkfield="tagfield";
my $offset=$input->param('offset');
my $script_name="/cgi-bin/koha/admin/marc_subfields_structure.pl";
my ($template, $borrowernumber, $cookie)
= get_template_and_user({template_name => "parameters/marc_subfields_structure.tmpl",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => {parameters => 1},
debug => 1,
});
my $pagesize=30;
my $op = $input->param('op');
$tagfield=~ s/\,//g;
if ($op) {
$template->param(script_name => $script_name,
tagfield =>$tagfield,
frameworkcode => $frameworkcode,
$op => 1); # we show only the TMPL_VAR names $op
} else {
$template->param(script_name => $script_name,
tagfield =>$tagfield,
frameworkcode => $frameworkcode,
else => 1); # we show only the TMPL_VAR names $op
}
################## ADD_FORM ##################################
# called by default. Used to create form to add or modify a record
if ($op eq 'add_form') {
my $data;
my $dbh = C4::Context->dbh;
my $more_subfields = $input->param("more_subfields")+1;
# builds kohafield tables
my @kohafields;
push @kohafields, "";
my $sth2=$dbh->prepare("SHOW COLUMNS from biblio");
$sth2->execute;
while ((my $field) = $sth2->fetchrow_array) {
push @kohafields, "biblio.".$field;
}
my $sth2=$dbh->prepare("SHOW COLUMNS from biblioitems");
$sth2->execute;
while ((my $field) = $sth2->fetchrow_array) {
if ($field eq 'notes') { $field = 'bnotes'; }
push @kohafields, "biblioitems.".$field;
}
my $sth2=$dbh->prepare("SHOW COLUMNS from items");
$sth2->execute;
while ((my $field) = $sth2->fetchrow_array) {
push @kohafields, "items.".$field;
}
# other subfields
push @kohafields, "additionalauthors.author";
push @kohafields, "bibliosubject.subject";
push @kohafields, "bibliosubtitle.subtitle";
# build authorised value list
$sth2->finish;
$sth2 = $dbh->prepare("select distinct category from authorised_values");
$sth2->execute;
my @authorised_values;
push @authorised_values,"";
while ((my $category) = $sth2->fetchrow_array) {
push @authorised_values, $category;
}
push (@authorised_values,"branches");
push (@authorised_values,"itemtypes");
# build thesaurus categories list
$sth2->finish;
$sth2 = $dbh->prepare("select authtypecode from auth_types");
$sth2->execute;
my @authtypes;
push @authtypes,"";
while ((my $authtypecode) = $sth2->fetchrow_array) {
push @authtypes, $authtypecode;
}
# build value_builder list
my @value_builder=('');
# read value_builder directory.
# 2 cases here : on CVS install, $cgidir does not need a /cgi-bin
# on a standard install, /cgi-bin need to be added.
# test one, then the other
my $cgidir = C4::Context->intranetdir ."/cgi-bin/koha";
unless (opendir(DIR, "$cgidir/value_builder")) {
$cgidir = C4::Context->intranetdir;
opendir(DIR, "$cgidir/value_builder") || die "can't opendir $cgidir/value_builder: $!";
}
while (my $line = readdir(DIR)) {
if ($line =~ /\.pl$/) {
push (@value_builder,$line);
}
}
closedir DIR;
# build values list
my $sth=$dbh->prepare("select * from marc_subfield_structure where tagfield=? and frameworkcode=?"); # and tagsubfield='$tagsubfield'");
$sth->execute($tagfield,$frameworkcode);
my @loop_data = ();
my $toggle=1;
my $i=0;
while ($data =$sth->fetchrow_hashref) {
my %row_data; # get a fresh hash for the row data
if ($toggle eq 1){
$toggle=0;
} else {
$toggle=1;
}
$row_data{tab} = CGI::scrolling_list(-name=>'tab',
-id=>"tab$i",
-values=>['-1','0','1','2','3','4','5','6','7','8','9','10'],
-labels => {'-1' =>'ignore','0'=>'0','1'=>'1',
'2' =>'2','3'=>'3','4'=>'4',
'5' =>'5','6'=>'6','7'=>'7',
'8' =>'8','9'=>'9','10'=>'items (10)',
},
-default=>$data->{'tab'},
-size=>1,
-multiple=>0,
);
$row_data{tagsubfield} =$data->{'tagsubfield'}." [input] {'tagsubfield'}."\" id=\"tagsubfield\">";
$row_data{liblibrarian} = CGI::escapeHTML($data->{'liblibrarian'});
$row_data{libopac} = CGI::escapeHTML($data->{'libopac'});
$row_data{seealso} = CGI::escapeHTML($data->{'seealso'});
$row_data{kohafield}= CGI::scrolling_list( -name=>"kohafield",
-id=>"kohafield$i",
-values=> \@kohafields,
-default=> "$data->{'kohafield'}",
-size=>1,
-multiple=>0,
);
$row_data{authorised_value} = CGI::scrolling_list(-name=>'authorised_value',
-id=>'authorised_value',
-values=> \@authorised_values,
-default=>$data->{'authorised_value'},
-size=>1,
-multiple=>0,
);
$row_data{value_builder} = CGI::scrolling_list(-name=>'value_builder',
-id=>'value_builder',
-values=> \@value_builder,
-default=>$data->{'value_builder'},
-size=>1,
-multiple=>0,
);
$row_data{authtypes} = CGI::scrolling_list(-name=>'authtypecode',
-id=>'authtypecode',
-values=> \@authtypes,
-default=>$data->{'authtypecode'},
-size=>1,
-multiple=>0,
);
$row_data{repeatable} = CGI::checkbox(-name=>"repeatable$i",
-checked => $data->{'repeatable'}?'checked':'',
-value => 1,
-label => '',
-id => "repeatable$i");
$row_data{mandatory} = CGI::checkbox(-name => "mandatory$i",
-checked => $data->{'mandatory'}?'checked':'',
-value => 1,
-label => '',
-id => "mandatory$i");
$row_data{hidden} = CGI::checkbox( -name=>"hidden$i",
-id => "hidden$i",
-checked => $data->{'hidden'}?'checked':'',
-value => 1,
-label => '');
$row_data{isurl} = CGI::checkbox( -name => "isurl$i",
-id => "isurl$i",
-checked => $data->{'isurl'}?'checked':'',
-value => 1,
-label => '');
$row_data{row} = $i;
$row_data{toggle} = $toggle;
$row_data{link} = CGI::escapeHTML($data->{'link'});
push(@loop_data, \%row_data);
$i++;
}
# add more_subfields empty lines for add if needed
for (my $i=1;$i<=$more_subfields;$i++) {
my %row_data; # get a fresh hash for the row data
$row_data{tab} = CGI::scrolling_list(-name=>'tab',
-id => "tab$i",
-values=>['-1','0','1','2','3','4','5','6','7','8','9','10'],
-labels => {'-1' =>'ignore','0'=>'0','1'=>'1',
'2' =>'2','3'=>'3','4'=>'4',
'5' =>'5','6'=>'6','7'=>'7',
'8' =>'8','9'=>'9','10'=>'items (10)',
},
-default=>"",
-size=>1,
-multiple=>0,
);
$row_data{tagsubfield} = " [input] {'tagsubfield'}."\" size=\"1\" id=\"tagsubfield\" maxlength=\"1\">";
$row_data{liblibrarian} = "";
$row_data{libopac} = "";
$row_data{seealso} = "";
$row_data{repeatable} = CGI::checkbox( -name=> 'repeatable',
-id => "repeatable$i",
-checked => '',
-value => 1,
-label => '');
$row_data{mandatory} = CGI::checkbox( -name=> 'mandatory',
-id => "mandatory$i",
-checked => '',
-value => 1,
-label => '');
$row_data{hidden} = CGI::checkbox( -name => 'hidden',
-id => "hidden$i",
-checked=> '',
-value => 1,
-label => '');
$row_data{isurl} = CGI::checkbox(-name => 'isurl',
-id => "isurl$i",
-checked => '',
-value => 1,
-label => '');
$row_data{kohafield}= CGI::scrolling_list( -name=>'kohafield',
-id => "kohafield$i",
-values=> \@kohafields,
-default=> "",
-size=>1,
-multiple=>0,
);
$row_data{authorised_value} = CGI::scrolling_list(-name=>'authorised_value',
-id => 'authorised_value',
-values=> \@authorised_values,
-size=>1,
-multiple=>0,
);
$row_data{authtypes} = CGI::scrolling_list(-name=>'authtypecode',
-id => 'authtypecode',
-values=> \@authtypes,
-size=>1,
-multiple=>0,
);
$row_data{link} = CGI::escapeHTML($data->{'link'});
$row_data{toggle} = $toggle;
$row_data{row} = $i;
push(@loop_data, \%row_data);
}
$template->param('use-heading-flags-p' => 1);
$template->param('heading-edit-subfields-p' => 1);
$template->param(action => "Edit subfields",
tagfield => " [input] $tagfield",
loop => \@loop_data,
more_subfields => $more_subfields,
more_tag => $tagfield);
# END $OP eq ADD_FORM
################## ADD_VALIDATE ##################################
# called by add_form, used to insert/modify data in DB
} elsif ($op eq 'add_validate') {
my $dbh = C4::Context->dbh;
$template->param(tagfield => "$input->param('tagfield')");
my $sth=$dbh->prepare("replace marc_subfield_structure (tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,authtypecode,value_builder,hidden,isurl,frameworkcode, link)
values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)");
my @tagsubfield = $input->param('tagsubfield');
my @liblibrarian = $input->param('liblibrarian');
my @libopac = $input->param('libopac');
my @kohafield = $input->param('kohafield');
my @tab = $input->param('tab');
my @seealso = $input->param('seealso');
my @authorised_values = $input->param('authorised_value');
my @authtypecodes = $input->param('authtypecode');
my @value_builder =$input->param('value_builder');
my @link =$input->param('link');
for (my $i=0; $i<= $#tagsubfield ; $i++) {
my $tagfield =$input->param('tagfield');
my $tagsubfield =$tagsubfield[$i];
$tagsubfield="@" unless $tagsubfield ne '';
my $liblibrarian =$liblibrarian[$i];
my $libopac =$libopac[$i];
my $repeatable =$input->param("repeatable$i")?1:0;
my $mandatory =$input->param("mandatory$i")?1:0;
my $kohafield =$kohafield[$i];
my $tab =$tab[$i];
my $seealso =$seealso[$i];
my $authorised_value =$authorised_values[$i];
my $authtypecode =$authtypecodes[$i];
my $value_builder=$value_builder[$i];
my $hidden = $input->param("hidden$i")?1:0;
my $isurl = $input->param("isurl$i")?1:0;
my $link = $link[$i];
if ($liblibrarian) {
unless (C4::Context->config('demo') eq 1) {
$sth->execute ($tagfield,
$tagsubfield,
$liblibrarian,
$libopac,
$repeatable,
$mandatory,
$kohafield,
$tab,
$seealso,
$authorised_value,
$authtypecode,
$value_builder,
$hidden,
$isurl,
$frameworkcode,
$link,
);
}
}
}
$sth->finish;
print "Content-Type: text/html\n\n ";
exit;
# END $OP eq ADD_VALIDATE
################## DELETE_CONFIRM ##################################
# called by default form, used to confirm deletion of data in DB
} elsif ($op eq 'delete_confirm') {
my $dbh = C4::Context->dbh;
my $sth=$dbh->prepare("select * from marc_subfield_structure where tagfield=? and tagsubfield=? and frameworkcode=?");
#FIXME : called with 2 bind variables when 3 are needed
$sth->execute($tagfield,$tagsubfield);
my $data=$sth->fetchrow_hashref;
$sth->finish;
$template->param(liblibrarian => $data->{'liblibrarian'},
tagsubfield => $data->{'tagsubfield'},
delete_link => $script_name,
tagfield =>$tagfield,
tagsubfield => $tagsubfield,
frameworkcode => $frameworkcode,
);
# END $OP eq DELETE_CONFIRM
################## DELETE_CONFIRMED ##################################
# called by delete_confirm, used to effectively confirm deletion of data in DB
} elsif ($op eq 'delete_confirmed') {
my $dbh = C4::Context->dbh;
unless (C4::Context->config('demo') eq 1) {
my $sth=$dbh->prepare("delete from marc_subfield_structure where tagfield=? and tagsubfield=? and frameworkcode=?");
$sth->execute($tagfield,$tagsubfield,$frameworkcode);
$sth->finish;
}
print "Content-Type: text/html\n\n ";
exit;
$template->param(tagfield => $tagfield);
# END $OP eq DELETE_CONFIRMED
################## DEFAULT ##################################
} else { # DEFAULT
my $env;
my ($count,$results)=StringSearch($env,$tagfield,$frameworkcode);
my $toggle=1;
my @loop_data = ();
for (my $i=$offset; $i < ($offset+$pagesize<$count?$offset+$pagesize:$count); $i++){
if ($toggle eq 1){
$toggle=0;
} else {
$toggle=1;
}
my %row_data; # get a fresh hash for the row data
$row_data{tagfield} = $results->[$i]{'tagfield'};
$row_data{tagsubfield} = $results->[$i]{'tagsubfield'};
$row_data{liblibrarian} = $results->[$i]{'liblibrarian'};
$row_data{kohafield} = $results->[$i]{'kohafield'};
$row_data{repeatable} = $results->[$i]{'repeatable'};
$row_data{mandatory} = $results->[$i]{'mandatory'};
$row_data{tab} = $results->[$i]{'tab'};
$row_data{seealso} = $results->[$i]{'seealso'};
$row_data{authorised_value} = $results->[$i]{'authorised_value'};
$row_data{authtypecode} = $results->[$i]{'authtypecode'};
$row_data{value_builder} = $results->[$i]{'value_builder'};
$row_data{hidden} = $results->[$i]{'hidden'};
$row_data{isurl} = $results->[$i]{'isurl'};
$row_data{link} = $results->[$i]{'link'};
$row_data{delete} = "$script_name?op=delete_confirm&tagfield=$tagfield&tagsubfield=".$results->[$i]{'tagsubfield'}."&frameworkcode=$frameworkcode";
$row_data{toggle} = $toggle;
if ($row_data{tab} eq -1) {
$row_data{subfield_ignored} = 1;
}
push(@loop_data, \%row_data);
}
$template->param(loop => \@loop_data);
$template->param(edit_tagfield => $tagfield,
edit_frameworkcode => $frameworkcode);
if ($offset>0) {
my $prevpage = $offset-$pagesize;
$template->param(prev =>"");
}
if ($offset+$pagesize<$count) {
my $nextpage =$offset+$pagesize;
$template->param(next => "");
}
} #---- END $OP eq DEFAULT
output_html_with_http_headers $input, $cookie, $template->output;
---------------------------------
Blab-away for as little as 1¢/min. Make PC-to-Phone Calls using Yahoo! Messenger with Voice.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-win32/attachments/20060404/7684d125/attachment-0001.htm>
More information about the Koha-win32
mailing list