[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Feb 4 00:27:10 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #10)
> Hi, 
> 
> there is one noticeable and big difference: With the patch you see the
> optgroups of budgets, even if there are no funds listed below. That makes
> the list grow long, especially as it also includes the inactive ones by
> default.
> 
> Combinations I tested:
> - Active budget with multi-level funds - ok
> - Inactive budget with fund - not ok, budget is listed
> - Locked budget with fund - not ok, budget is listed
> - Active budget with funds that are not accessible by permission 
>   (restricted to owner) - not ok
>   This would for example be used to separate budgets and funds of different
>   libraries in a system and could also make the list quite long.
> 
> I really like the idea of this improvement, but I think we are not there yet.

Do you know if this is comparable to orderreceive.tt? My original plan was just
to bring parcels.tt and newemptyorder.tt in line with that template.

Did inactive and locked budgets not show before the patch?

I'm not sure I understand the "accessible by permission" part. I think the code
for that is identical before and after the patch?

If the list were long, I would think having optgroup tags would be essential
for organising them? Otherwise the select list would be difficult to navigate.
I'm not sure that I understand this part of the feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list