[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jul 9 14:47:35 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #3)
> When seeing this, I wonder right away why not the other one?
> 
> -    my $query        = $operands[0];
> +    my $query        = $operands[0] // "";
>      my $simple_query = $operands[0];
> 
> And looking a bit later, I see:
>     for ($query_cgi,$simple_query) {
>         s/"//g;
>     }
> Shouldnt this trigger a warn too when undefined?

The code sets it undef later, and simple_query is not used between the two
places

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list