[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #5)
> (In reply to Marcel de Rooy from comment #3)
> > When seeing this, I wonder right away why not the other one?
> > 
> > -    my $query        = $operands[0];
> > +    my $query        = $operands[0] // "";
> >      my $simple_query = $operands[0];
> > 
> > And looking a bit later, I see:
> >     for ($query_cgi,$simple_query) {
> >         s/"//g;
> >     }
> > Shouldnt this trigger a warn too when undefined?
> 
> The code sets it undef later, and simple_query is not used between the two
> places

Hmm. Not important but I do not see that it is set to undef later, and if it
is, then it will surely trigger the uninitialized warn that we want to resolve.
If it is not set, then it depends on $operands[0]

-- 
You are receiving this mail because:
You are watching all bug changes.