[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
OK Cant find bad calls that easy ;) WHich doesnt say there are none!
What I did:

=== cd Koha; git grep -E "return.*s\->_new_from_dbic"
=> Find routines that directly return a new_from_dbic with a plural object
DONE Account/Line.pm
DONE Acquisition/Basket.pm
DONE Acquisition/Bookseller.pm
DONE Acquisition/Order.pm
DONE Biblio.pm
Cash/Register.pm
Checkouts/ReturnClaims.pm
DONE Clubs.pm
DONE Course/Item.pm
Illrequest.pm
DONE Item.pm
DONE Library.pm
Object.pm
Object/Mixin/AdditionalFields.pm
Objects.pm
DONE Patron.pm
Patrons.pm
StockRotationRota.pm

Within that module, I looked for the specific subs that do it:
Biblio: items, orders, suggestions, cover_images
Patron: holds,checkouts, pending_checkouts, old_checkouts, get_routing_lists,
old_holds, return_claims, extended_attributes
Item: holds, cover_images,orders,   get_transfers, current_holds, tracked_links
Account/Line: credit_offsets, debit_offsets, credits, debits
Acquisition/Bookseller: baskets, contacts
Acquisition/Order: claims
Course/Item.pm: course_reserves
Library.pm: stockrotationstages, outgoing_transfers, inbound_transfers,
library_groups,  cash_registers

For each of these subs, I grepped something like:
git grep -E "\->\s*debits(\s*,|$)"

Which should find occurrences where $blabla-> debits, might be in a list or
function call etc.

So far, so good.

-- 
You are receiving this mail because:
You are watching all bug changes.