[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327

--- Comment #47 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Nick Clemens from comment #46)
> (In reply to Fridolin Somers from comment #45)
> > Created attachment 136381 [details] [review] [review]
> > Bug 28327: Unify CSV delimiter special behavior for tabulation
> 
> It looks like you default to ';' but the majority of code you change
> defaulted to ',' - can you explain what made you choose seimcolon? I would
> think comma makes a better default

Mmm it is the default value in installer/data/mysql/mandatory/sysprefs.sql.

Actual fallback values is often comma indeed :
 > git grep "CSVDelimiter') ||" | grep -v misc/translator/
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/lateorders.tt:[%-
SET delimiter = Koha.Preference('CSVDelimiter') || ',' -%]
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt:[%-
SET delimiter = Koha.Preference('CSVDelimiter') || ',' -%]
misc/cronjobs/fines.pl:my $delim = "\t";    # ? 
C4::Context->preference('CSVDelimiter') || "\t";
misc/cronjobs/overdue_notices.pl:    my $sep_char =
C4::Context->preference('CSVDelimiter') || ';';
misc/cronjobs/overdue_notices.pl:            my $delimiter =
C4::Context->preference('CSVDelimiter') || ';';
misc/export_borrowers.pl:    $separator =
C4::Context->preference('CSVDelimiter') || ',';
reports/bor_issues_top.pl:our $sep     = $input->param("sep") ||
C4::Context->preference('CSVDelimiter') || ',';
reports/cash_register_stats.pl:        my $delimiter =
C4::Context->preference('CSVDelimiter') || ',';
reports/guided_reports.pl:            my $delimiter =
C4::Context->preference('CSVDelimiter') || ',';
tools/viewlog.pl:        my $delimiter =
C4::Context->preference('CSVDelimiter') || ',';

May we change installer ?

-- 
You are receiving this mail because:
You are watching all bug changes.