[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327

--- Comment #48 from David Nind <david at davidnind.com> ---
Test fail for t/Koha_Template_Plugin_Koha.t:

prove t/Koha_Template_Plugin_Koha.t
t/Koha_Template_Plugin_Koha.t .. 1/5 
    #   Failed test 'CSVDelimiter() returns comma when preference is empty
string'
    #   at t/Koha_Template_Plugin_Koha.t line 99.
    #          got: ';'
    #     expected: ','

    #   Failed test 'CSVDelimiter() returns comma when preference is undefined'
    #   at t/Koha_Template_Plugin_Koha.t line 102.
    #          got: ';'
    #     expected: ','
    # Looks like you failed 2 tests of 8.

#   Failed test 'Koha::Template::Plugin::Koha::CSVDelimiter tests'
#   at t/Koha_Template_Plugin_Koha.t line 115.
# Looks like you failed 1 test of 5.
t/Koha_Template_Plugin_Koha.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests 

Test Summary Report
-------------------
t/Koha_Template_Plugin_Koha.t (Wstat: 256 Tests: 5 Failed: 1)
  Failed test:  5
  Non-zero exit status: 1
Files=1, Tests=5,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.42 cusr  0.04
csys =  0.49 CPU)
Result: FAIL

Like Nick, I think comma separated makes more sense to me as the default.
(comment #46).

I tested a couple of places and exported as tab separated - now works as per
the test plan (properly tab separated, not the word tabulation). Places tested:
Item search, Log viewer.

-- 
You are receiving this mail because:
You are watching all bug changes.