[Koha-bugs] [Bug 30215] "Item found" in accountlines untranslatable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30215

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The problem is here:

                my $credit;
                if ( $credit_total > 0 ) {
                    my $branchcode =
                      C4::Context->userenv ? C4::Context->userenv->{'branch'} :
undef;
                    $credit = $account->add_credit(
                        {
                            amount      => $credit_total,
                            description => 'Item found ' . $self->itemnumber,
                            type        => 'LOST_FOUND',
                            interface   => C4::Context->interface,
                            library_id  => $branchcode,
                            item_id     => $self->itemnumber,
                            issue_id    => $lost_charge->issue_id
                        }
                    );

Having the description option seems to be a bad idea in the first place when
it's not used for adding variables like the title, due date etc. Always meant
trouble for translations.

I also agree about the itemnumber not being useful. We do have the link to the
item displaying in the table, there is no need for it in the description.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.