[Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Overall this looks great and I am quite happy to see the code has been moved to
an include. Some small 'complaints', hopefully all easy to fix:

1) Translation

I believe we now need to change this to use the single underscore as it was
moved from a .js to an .inc file:

+                content = __("Unable to claim as returned");

2) Column configuration

The new column should be added to the column configuration for this report.
Some libraries are not using the return claims feature and then it's nice when
it can be hidden by default and it also helps when you want to print the table
to slim it down.

3) QA test tools

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
   FAIL   valid_template
                modal-claims-js: not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
   FAIL   filters
                missing_filter at line 125 (                <span
class="badge">[% overdueloo.return_claim_created_on %]</span>)

-- 
You are receiving this mail because:
You are watching all bug changes.