[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #92 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting here:

1) QA test tools

Processing files before patches
|========================>| 18 / 18 (100.00%)
Processing files after patches
No schema file found for table debarment_types at
/kohadevbox/qa-test-tools/QohA/File/Specific/Kohastructure.pm line 118.
No schema file found for table debarment_types at
/kohadevbox/qa-test-tools/QohA/File/Specific/Kohastructure.pm line 118.
|========================>| 18 / 18 (100.00%)

 FAIL   Koha/RestrictionType.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)

 FAIL   Koha/RestrictionTypes.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)

 FAIL   admin/restrictions.pl
   FAIL   critic
                Subroutine "new" called using indirect syntax at line 27,
column 13. See page 349 of PBP.
   FAIL   forbidden patterns
                forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 38)

 OK     circ/circulation.pl
 OK     installer/data/mysql/kohastructure.sql
 OK     installer/data/mysql/mandatory/sysprefs.sql
 FAIL   koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
   FAIL   css_and_scss_in_sync
                Found CSS file not in sync with its SCSS file, use yarn build.
This is not blocker, testers can generate the .css file if they need it, see
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

 OK     koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc
 OK     koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
   FAIL   forbidden patterns
                forbidden pattern: Title elements must start with the unique
information (bug 26703) (line 6)

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
 OK     koha-tmpl/intranet-tmpl/prog/js/restrictiontypes.js
 OK     members/memberentry.pl
 OK     members/mod_debarment.pl
 OK     members/moremember.pl
 FAIL   t/db_dependent/RestrictionType.t
   FAIL   file permissions
                File must have the exec flag

 FAIL   t/db_dependent/RestrictionTypes.t
   FAIL   file permissions
                File must have the exec flag

2) Sample data for installer

The sample data added here is .sql not a .yml, but they might contain strings
to translate. Can you please verify?
But we still need the .sql files to add to the remaining 'old style'
installers.

3) Database structure

ronly and dflt could be improved as column names. ronly = read only, but dlft?
Otherwise as far as I can tell it all seems to match up between new and updated
installations.

4) Preference

So the preference is only about the pull down when adding a patron restriction,
correct? If you want to make me really happy, please and with a . :) But I
believe options need to be changed to 1 and 0?

+         - pref: PatronRestrictionTypes
+           choices:
+               yes: Allow
+               no: Don't allow
+         - "the type of patron restriction to be specified when applying
manually"


5) Page title

It needs to be updated to reflect the accessibility work starting with the most
specific bits, but I think the QA tool already caught that:

+<title>Koha › Administration › Patron restrictions › [%
IF op == 'add_form' %][% IF ( restriction ) %]Modify restriction '[%
restriction.display_text | html %]'[% ELSE %]New restriction[% END %][% END %]

6) New permission - OK

I wondered if the new permission should be assigned to someone... but I guess
it works ok. If the user has module permission already, they will have
permission for the new page. Otherwise it will have to be assigned, but
existing functionality keeps working meanwhile. So all good.

-- 
You are receiving this mail because:
You are watching all bug changes.