[Koha-bugs] [Bug 30733] Simplify translatable strings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Some testing notes before I forget.

- it has been checked multiple times that no <span> has been added to a <title>
- attention was given to leave out CSV and JSON outputs
- each .inc was checked individually to ensure it's indeed HTML and not CSV,
JSON or the content of a <title>
- via doing searches in the git log for <span> and </span> it's possible to be
very confident that there is not typo in the tag and not mismatching of tags
(same method used on bug 29602 that worked well to find little mistakes)
- one proofreading pass was especially focused in ensuring that IF and ELSE
couldn't cause a tag mismatch
- QA test tools pass albeit some unusual Perl warnings outputted by the script:

root at kohadevbox:koha(simplify-translatable-strings)$ time
/kohadevbox/qa-test-tools/koha-qa.pl -v 2 -c 1
testing 1 commit(s) (applied to 68990b9 '9a Bug 30722: Typo in overdue
recalls')

Processing files before patches
File not found : lib/jquery/jquery-ui-1.13.1.css at
/kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 130.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 130.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 236.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
line 343.
|========================>| 116 / 116 (100.00%)
Processing files after patches
File not found : lib/jquery/jquery-ui-1.13.1.css at
/kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 130.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 130.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 236.
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
line 343.
|========================>| 116 / 116 (100.00%)

-- 
You are receiving this mail because:
You are watching all bug changes.