[Koha-bugs] [Bug 30733] Simplify translatable strings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733

--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Fridolin Somers from comment #2)
> In text above you forgot to remove 'type' in second line, after [% END %].
> 
> But it is OK in patch :

Indeed I mess up the manual example, sorry for the confusion.


> Still I think there is a problem.
> 
> This will lead to the translation of :
>   "Payment type"
>   "Transaction type"
>   "%s: "

A diff between updated strings on master and updated strings with the patch
shows by searching for the location comment "transaction_types.inc" that
"Payment type" is created
"Transaction type" already exists and the location "transaction_types.inc" is
added in it's list
No other "transaction_types.inc" to be found that could show that "%s: " is
created or linked to an existing one


> Usually the ":" is with translated text :
>   "Payment type: "
>   "Transaction type: "

ok, shall I make all the strings include the ":" ?
In your above example I see a trailing space after the semicolon but we don't
aim for this in source strings right?


> You may add a span for ending character alone :
> +            <label for="[% type | html %]_type" class="required">[% IF type
> == 'payment' %]<span>Payment type</span>[% ELSE %]<span>Transaction
> type</span>[% END %]<span>: </span></label>
> But the context may be hard to understand for translators.

Translators probably will just copy it as it without deducing they can there
decide their punctuation spacing style. Assuming the string extraction script
keeps it. But it seems not from a check above.

-- 
You are receiving this mail because:
You are watching all bug changes.