[Koha-bugs] [Bug 32036] Cannot set single sub-permission without also setting the top level flag

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Cook from comment #4)
> (In reply to Nick Clemens from comment #3)
> > I think this causes confusion then - either we should always have a single
> > subpermission, or we should only have them if we have two?
> 
> Confusion for whom?

For developers, or users. Why does problem reports have a subpermission, and
edit authorities does not?

> 
> > For OPAC problem reports - we only seem to ever check the top permission
> > For recalls we check the subpermission every time, except once
> >
> > Having two settings with the same behavior seems wrong to me
> 
> What do you mean by "two settings"?

flagsrequired   => { recalls => "manage_recalls" }
flagsrequired => { recalls => 1 }

These are checking two different things, but provide the same answer

> 
> For "OPAC problem reports management" and "Recalls", you get the same thing
> whether you click the top level or the sub-permission, and that's clearly
> indicated visually.

Sure, but then why is the subpermission added at all? If it is the same as
clicking the top level, let's not provide two checkboxes when one will do

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.