[Koha-bugs] [Bug 32036] Cannot set single sub-permission without also setting the top level flag

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #5)
> (In reply to David Cook from comment #4)
> > Confusion for whom?
> 
> For developers, or users. Why does problem reports have a subpermission, and
> edit authorities does not?

Ahh, I understand now. That is confusing. My only thought is that the original
developer thought that additional sub-permissions might be added?

Aleisha could probably speak to that for recalls. 

> > What do you mean by "two settings"?
> 
> flagsrequired   => { recalls => "manage_recalls" }
> flagsrequired => { recalls => 1 }
> 
> These are checking two different things, but provide the same answer

That's true (where there is only one sub-permission like recalls). 

If additional sub-permissions were added, they would mean different things. I
suppose that is both a pro and a con...

> > For "OPAC problem reports management" and "Recalls", you get the same thing
> > whether you click the top level or the sub-permission, and that's clearly
> > indicated visually.
> 
> Sure, but then why is the subpermission added at all? If it is the same as
> clicking the top level, let's not provide two checkboxes when one will do

I think that's the crux of the matter. 

I suppose one option could be removing unnecessary sub-permissions? 

Alternatively, we could also grey-out sub-permissions where there's only 1
sub-permission available. That might make it less confusing visually?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.