[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
I tried to solve the same issue but fixed it differently (I didn't know about
this bug report until now)
I tested this bug's patches and it doesn't work for me. I used the following
test plan:
1. Apply patch
2. Disable AllowHoldPolicyOverride
3. Create a biblio B with an item I at library A.
4. Configure this library A to not be a pickup location
5. Add a "Default holds policy by item type" for item I type where "Hold
   pickup library match" is "item's home library"
6. Try to place a hold on biblio B
   You should not be able to place a hold because there is no valid
   pickup locations
7. Enable AllowHoldPolicyOverride
8. Try to place a hold on biblio B
   You should now see all valid pickup locations in a dropdown list
   (with an exclamation mark in front of each option) with none selected
   by default
9. Verify you can place a title-level hold and an item-level hold

At step 8, I still see the error message "No items are available to be placed
on hold." and the message " No valid pickup location " in the items table.
"Place hold" buttons are disabled.

Here's my patch:
https://git.biblibre.com/biblibre/kohac/commit/a1fe134264a855a13b2586545475b5256deef10d

Should I submit my patch in another bug report (as this one is already Passed
QA) ?

-- 
You are receiving this mail because:
You are watching all bug changes.