[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #51 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased and reworked. The original patch had a problem that caused
infinite recursion (CanItemBeReserved called IsAvailableForItemLevelRequest
which called ItemsAnyAvailableAndNotRestricted which called CanItemBeReserved)

Replaced the call to IsAvailableForItemLevelRequest by a call to a new
subroutine IsOnShelfHoldsPolicySatisfied which does only what its name suggests

All tests mentioned in comment 44 should pass.

I removed the Signed-off-by lines because the patch changed significantly, but
the test plan did not change. Please test again

-- 
You are receiving this mail because:
You are watching all bug changes.