[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #52 from Nick Clemens <nick at bywatersolutions.com> ---
I believe other calls to CanItemBeRserved should be adjusted or taken into
consideration

Both reserve/request.pl and opac/opac-reserve.pl currently call
CanItemBeReserved and then call IsAvailableForItemLevelRequest

After this code, if I understand correctly, IsOnShelfHoldsPolicySatisfied will
now be called twice for each item - once from CanItem.. and once from
IsAvailable..

See bug 32702 - we really need to consolidate these two routines, or if a check
is moved into CanItemBeReserved, it should be removed from the other?

-- 
You are receiving this mail because:
You are watching all bug changes.