[Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #7)
> Should we clear on all plugin-related test files? subtests? Should we
> generalize this cleanup step? I know we rollback, and then call ->delete()
> in some places, we should just add this cache cleaning too.
> 
> $ ls t/db_dependent/Koha/Plugins/
> Account_hooks.t*                 Broken.t*                        Patron.t*
> BackgroundJob.t*                 Circulation_hooks.t*             Plugins.t*
> Barcode_transform_hooks.t*       Holds_hooks.t*                  
> Recall_hooks.t*
> Biblio_and_Items_plugin_hooks.t* KitchenSinkPlugin.kpz           
> authority_hooks.t*

BackgroundJob.t does:
    $schema->storage->txn_rollback;
    Koha::Plugins::Methods->delete;
Thats definitely in the wrong order.
Same for Barcode_transform_hooks.t
Copy/paste? Recall_hooks.t Biblio_and_Items_plugin_hooks.t
Etc

Yes, we should do some cleanup here !

A valid question is however why did we not see this failure much more? It
surely depends on the excecution order of test scripts.

This still needs a bit more digging. Will try now.

-- 
You are receiving this mail because:
You are watching all bug changes.