[Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Most of the time it is wrong. If you would have plugins on your system, they
are removed too.

git grep -C1 -P "Plugins::Methods?->delete"

t/db_dependent/Koha/Plugins/Account_hooks.t-
t/db_dependent/Koha/Plugins/Account_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Account_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/BackgroundJob.t-    $schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/BackgroundJob.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/BackgroundJob.t-};
--
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-};
--
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-};
--
t/db_dependent/Koha/Plugins/Circulation_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Circulation_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Circulation_hooks.t-};
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Account_hooks.t-
t/db_dependent/Koha/Plugins/Account_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Account_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/BackgroundJob.t-    $schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/BackgroundJob.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/BackgroundJob.t-};
--
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-};
--
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-};
--
t/db_dependent/Koha/Plugins/Circulation_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Circulation_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Circulation_hooks.t-};
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Patron.t-    $schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Patron.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Patron.t-};
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
root at master:/usr/share/koha# git grep -C1 -P "Plugins::Methods?->delete"
t/db_dependent/Koha/Plugins/Account_hooks.t-
t/db_dependent/Koha/Plugins/Account_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Account_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/BackgroundJob.t-    $schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/BackgroundJob.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/BackgroundJob.t-};
--
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-};
--
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-};
--
t/db_dependent/Koha/Plugins/Circulation_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Circulation_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Circulation_hooks.t-};
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Patron.t-    $schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Patron.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Patron.t-};
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Make sure there's no previous
installs or leftovers on DB
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete;
--
t/db_dependent/Koha/Plugins/Plugins.t-$schema->storage->txn_begin;
t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-$schema->resultset('PluginData')->delete;
--
t/db_dependent/Koha/Plugins/Plugins.t-
t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete;
--
t/db_dependent/Koha/Plugins/Recall_hooks.t-
t/db_dependent/Koha/Plugins/Recall_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Recall_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/authority_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/authority_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/authority_hooks.t-};
root at master:/usr/share/koha# git grep -C1 -P "Plugins::Methods?->delete" > zzz
root at master:/usr/share/koha# cat zzz
t/db_dependent/Koha/Plugins/Account_hooks.t-
t/db_dependent/Koha/Plugins/Account_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Account_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/BackgroundJob.t-    $schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/BackgroundJob.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/BackgroundJob.t-};
--
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-};
--
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-};
--
t/db_dependent/Koha/Plugins/Circulation_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Circulation_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Circulation_hooks.t-};
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Holds_hooks.t-
t/db_dependent/Koha/Plugins/Holds_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Holds_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/Patron.t-    $schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/Patron.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Patron.t-};
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete();
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Temporarily remove any installed
plugins data
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-
--
t/db_dependent/Koha/Plugins/Plugins.t-    # Make sure there's no previous
installs or leftovers on DB
t/db_dependent/Koha/Plugins/Plugins.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-   
$schema->resultset('PluginData')->delete;
--
t/db_dependent/Koha/Plugins/Plugins.t-$schema->storage->txn_begin;
t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Plugins.t-$schema->resultset('PluginData')->delete;
--
t/db_dependent/Koha/Plugins/Plugins.t-
t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete;
--
t/db_dependent/Koha/Plugins/Recall_hooks.t-
t/db_dependent/Koha/Plugins/Recall_hooks.t:    Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/Recall_hooks.t-    $schema->storage->txn_rollback;
--
t/db_dependent/Koha/Plugins/authority_hooks.t-   
$schema->storage->txn_rollback;
t/db_dependent/Koha/Plugins/authority_hooks.t:   
Koha::Plugins::Methods->delete;
t/db_dependent/Koha/Plugins/authority_hooks.t-};

-- 
You are receiving this mail because:
You are watching all bug changes.