[Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Dec 11 11:23:50 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
=== Preliminary conclusion

When you call InstallPlugins, or plugin->enable or ->disable, the cache will
already be cleared. This covers quite a few cases. But not all, explaining for
a bit the reduced number of failures.
Things are definitely related to the KitchenSink stuff in Plugins.t and the
order of execution.

What about temporarily disabling plugins in TestBuilder.t ? Or in
build_sample_biblio ? Does not sound very nice. Not the way to go imo.

Adding a clear cache in Methods->delete probably works? Yes, we even catch the
Handler->delete case too. Since Handler->delete calls uninstall on the plugin.
Deletes from plugin_data. And does Methods->search->delete!
But it does not feel like the best solution imo. The actions for deleting
records in plugin_data and plugin_methods should be done on a general level and
not be repeated in all those test scripts etc. (Which requires more code
changes definitely. But reordering all deletes after rollback does require a
lot of those changes too..)

We need a simple fix that can be backported to versions having bug 29672 (i.e.
22.11) And an enhancement taking care of the cleanup and wrong order stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list