[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159823|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 159842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159842&action=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests

[1] Replace Methods->delete by RemovePlugins:
    git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Remove superfluous $schema->resultset('PluginData')->delete.
[3] Remove superfluous use Koha::Plugins::Methods.
[4] Add the line $plugins = Koha::Plugins->new in PluginRoutes.t.
    As originally done in a separate patch. This makes both parts
    of subtest 'needs_install use case tests' more consistent.
[5] Add RemovePlugins now in Handler->delete too.

Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.