[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159824|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 159843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159843&action=edit
Bug 35536: Remove Method->delete and reorder rollbacks

We removed the need for Method->delete, so we can remove
that.

Also we should now move all RemovePlugins calls BEFORE the last
rollback. Nice and clean :)

Test plan:
Search for wrong order with:
  grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins)
  No occurrences left? Think of another grep :)
Check number of records in plugin_data/methods.
Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
And check number of records again. Same?

Bonus: Install a plugin before following test plan.
You could use the attached 'DONT PUSH' example patch. Having 3 recs in data
and 45 in methods with that plugin only (before/after tests).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.