[Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 8 17:44:04 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909

Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Laura.escamilla at bywatersolu
                   |                            |tions.com
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> ---
(In reply to Andreas Roussos from comment #4)
> Created attachment 146391 [details] [review]
> Bug 32909: Load item type icons from the correct path
> 
> When placing an item-level hold in the Staff interface,
> the table at the bottom of the screen (under the "Place
> a hold on a specific item" heading) should display the
> icon associated with the item type of each item in the
> 'Item type' column.
> 
> This feature broke in v22.05.00 (for Debian package installs):
> instead of the item type icon you get the default 'broken
> image URL' image of your web browser.
> 
> This patch fixes that.
> 
> Test plan:
> 
> 1) (if needed) Configure the following System preferences:
>    - item-level_itypes => 'specific item'
>    - noItemTypeImages  => 'Show'
> 
> 2) (if needed) In Koha Administration > Item types, create
>    an item type and associate it with an icon
> 
> 3) (if needed) Create a test bibliographic record, and add
>    an item to it that has an item type with an icon
> 
> 4) Visit the bibliographic record's details page in the
>    Staff interface. Select 'Holds' on the left hand side,
>    then pick a patron. The "Place a hold on ..." page should
>    load. In the 'Item type' column of the table at the bottom
>    of the screen notice that instead of seeing the icon
>    associated with the item type of each item you get the
>    default 'broken image URL' image of your web browser [*]
> 
>    [*] In non-Debian package installs, the 'href' property
>        of the item type icon's <img> tag should start with
>        '/opac-tmpl/bootstrap/itemtypeimg'
> 
> 5) Apply this patch, restart Plack and refresh the page.
>    The item type icon should now be displayed correctly.
> 
>    KTD and Koha Sandboxes users: To verify the patch has
>    worked, you should right-click on the item type icon and
>    click 'Inspect': the 'href' property of the <img> tag
>    should now start with: '/intranet-tmpl/prog/img/itemtypeimg'

Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list