[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jul 3 09:28:14 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Why not remove:
+    # if the issue changed before the script got to it, then pass on it.
+    my $issue = Koha::Checkouts->find({ issue_id => $overdue->{issue_id} });
+    next if ( ! $issue );
+
+    my $datedue = dt_from_string( $overdue->{date_due} );
+    next unless $issue->is_overdue( $datedue );


And keep:
-    my $datedue = dt_from_string( $overdue->{date_due} );
-    if ( DateTime->compare( $datedue, $today ) == 1 ) {
-        next;    # not overdue
-    }

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list