[Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19361

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Trying to have a look at this with a set of fresh eyes :)

I've written some follow-ups for coding guidelines and to get the QA test tools
green, but the behavior is not quite right yet and this will need another look.

Test setup:
* CCODE: REF - amended description with -Fairfield and limited to Fairfield
library
* LOC: AV - amended description, limited to Fairfield
* Itemtype: BKS - amended description, limited to Fairfield
* Updated Henry from Midway to only have catalog and cataloguing permissions
* I am testing with an item that CCODE = REF and LOC = NOT AV, itemtype BKS


WITHOUT PATCH / BEFORE

1) Edit item form

* Henry (Midway)
  * CCODE of the item is REF: it shows in the pull down, but marked as: Not an
authorised value

    /!\ I believe this is a separate bug caused by bug 19361.
    It should not show as non-existing, but as limited. Same for itemtype.

  * LOC: AV is missing from the list. 
  * BK: (not an authorised value)

* Superlibrarian (Centerville) 
  * CCODE of the item if REF: Not an authorised value.
  * LOC: AV is missing.
  * Itype: BK (not an authorised value)

= Behaviour is the same for superlibrarians and users with limited permissions.

* Superlibrarian (Fairfield, login library)
  * CCODE, LOC and itype display normally.

2) Edit record form 

* Itype is not limited by branch and visible for Henry and superlibrarian.

  /!\ A different/new bug?


WITH PATCHES / AFTER

1) Edit item form

* Henry (Midway)
  * (improved) CCODE: It now shows with description and warning sign. 
  * (wrong) LOC: The limited value is now in the pull down list. It should not
be as the item is not using it.
  * (unchanged, wrong) BK: (not an authorised value). This should show the same
as CCODE.

* Superlibrarian (Fairfield)
  * (unchanged) CCODE, LOC and itype display normally.

2) Edit record form 

*  (unchanged) Itype is not limited by branch and visible for Henry and
superlibrarian. 


SUMMARY

I think we need to fix 2 things:

* The AV should only display in the list, if it's already used by the item.
Otherwise it should still remain hidden. This is the behaviour we have for
category codes on the patron edit forms.
* It looks like the code doesn't take the 'false' AV like itemtype into
account, but it should.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361
[Bug 19361] Linking an authorised value category to a field in a framework can
lose data
-- 
You are receiving this mail because:
You are watching all bug changes.