[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro.amorim at ptfs-europe.co
                   |                            |m

--- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Hi Marcel, I'm looking at this to attempt an SO but I'm not 100% familiar with
tests or Sitemapper.t.

My understanding of this patch is that we're cleaning up Sitemapper.t and
bringing it up to par a bit more with the most recent way of writing tests,
e.g. Slurp.

$schema->storage->txn_rollback; at the end also seems like something that was
missing and I believe it should've always been there?

I don't understand or see the need for the "FIXME" comment, if for the tests we
need to make sure the only biblios that exist are the 2 biblios we're creating
in the tests, isn't "Koha::Biblios->delete;" a perfectly fine way of doing it?

-- 
You are receiving this mail because:
You are watching all bug changes.