[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Pedro Amorim from comment #4)
> Hi Marcel, I'm looking at this to attempt an SO but I'm not 100% familiar
> with tests or Sitemapper.t.
> 
> My understanding of this patch is that we're cleaning up Sitemapper.t and
> bringing it up to par a bit more with the most recent way of writing tests,
> e.g. Slurp.
> 
> $schema->storage->txn_rollback; at the end also seems like something that
> was missing and I believe it should've always been there?
Yes

> I don't understand or see the need for the "FIXME" comment, if for the tests
> we need to make sure the only biblios that exist are the 2 biblios we're
> creating in the tests, isn't "Koha::Biblios->delete;" a perfectly fine way
> of doing it?
Yes, it works. And we do it more often in tests. But it is not the most elegant
way. So maybe TODO could have been more appropriate?

-- 
You are receiving this mail because:
You are watching all bug changes.