[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

Fri Jul 28 22:21:11 CEST 2023

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

--- Comment #31 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Hi Martin! 

Since you said you worked on it, I had another look at the sandbox with
bookings. 

> 
> Bugs:
> 
> -  The patron search doesn't work in the modal when you click the Place
> booking button when in "Item" tab https://snipboard.io/EDpzBr.jpg
> 

This works now!

>
> -  When you click on the Bookings tab, MARC and ISBD view disapears. 
> 

This is also fixed!

>
> -  In the bookings tab, the months appear in french (in the sandbox, which I
> assume only has english installed). https://snipboard.io/fCPapt.jpg Does it
> take the language from my computer? My Ubuntu is in English, and so is my
> Chrome...
> 

I still see the months in French. It's not that big of a deal, but very
mysterious.

>
> -  It seems the next day after a booking is not available? Also the calendar
> view and the table don't show the same dates.
>    To recreate:
>    1. Click Place booking
>    2. Place a booking for two days, for example May 22 and 23
>    3. Click Place booking again for the same item
>       --> Note that 22, 23 and 24 are greyed out
>    4. Place the booking for May 25-26
>    5. In the bookings tab, move the second booking to May 24-25
>       --> It worked
>    6. In the table, the dates are not updated
>       --> First booking in the calendar is 22-23, in the table it's 22-24
>       --> The second booking (the one that was moved) in the calendar is
> 24-25, in the table it's 25-27
> 

This is still the case.

My bookings are still taking one extra day than what I select. I'm guessing
this is by design? For example, I booked something from Sept. 2 to Sept. 4
https://snipboard.io/X4wGIL.jpg In the calendar view, I see it is booked from
the 2nd to the 4th, but in the table view, it says it's booked until the 5th.
https://snipboard.io/zmD3fu.jpg 

When I move it manually, it is not updated in the table.
https://snipboard.io/3fZbxj.jpg

>
> -  If you checkout early to the correct patron, the due date is still the
> start of the booking?
>    To recreate:
>    1. Place a booking for a couple days in the future, for example May 22-23
>    2. Attempt to check out to the same patron
>    3. Confirm early collection
>    4. Click Show checkotus
>       --> Due date is May 22
> 

This was fixed! Due date is now end date of the booking!

>
> Usability comments:
> 
> -  The patron search is not the same as elsewhere. I don't mind this version
> but for usability I think it would be best to have the same search
> everywhere.
>    (Summary of IRC discussions 
>    - Martin said the traditional search doesn't work well with modals
>    - Katrin said the traditional search works better for large datasets, so
> you can limit by library or category
>    - Martin said he'd work on a middle ground)
>    Maybe an alternative would be to make it work like the holds, i.e. send
> to a page with the form, the calendar and the table...
> 

I honestly don't remember what the patron search was before, if you changed it.
It is still different from any other patron search in Koha, and doesn't allow
to limit by library or category like Katrin mentioned. I don't think this would
be a blocker, I think most people would scan the card or type in the name. But
maybe something to think about in the future as we try to make Koha uniform and
consistent.

>
> -  I didn't catch right away that you had to choose two dates. It's nifty
> once you know, but elsewhere in Koha there are two field "From:" and "To:".
> 

This is still the case, although this time I knew! :P

>
> -  Will it eventually be possible to limit the number of days a patron can
> book for? Right now, a patron can hog an item for a very long time... I know
> you said circulation rules will be added later, is that what you meant?
> 

I don't think it this would be a blocker for now. However, I think we'd need
circulation rules shortly after this is added.

You said you weren't sure how to tie the circ rules in. I would see it as other
columns added to the gigantic circ rules table. 

Minimally :
- Booking allowed (number of "open" bookings patrons of this category can have
on items of this type at a time, default 0)
- Maximum booking period (maximum number of days (or hours if we eventually
allow this) each booking can be)
- Total bookings allowed (in the second table, maximum number of bookings per
patron regardless of category or item type)
- Total bookings allowed (in the third table, maximum number of bookings per
patron of this category, regardless of item type)

I also thought bookings could be set by item type (like, all LAPTOP items could
be bookable by default, etc.). Then you could use the flag on an item-per-item
basis if needed. It's just that if you have a lot of items you want to be
bookable, it's a pain to change them one by one as it is currently not an
option in the items batch modification form. That could be in a follow-up.

>
> -  The Holds tab shows how many holds there are, maybe the bookings tab
> should show if there are bookings and how many?
> 

This was added, thank you! I noticed however that when you add a booking, the
number doesn't automatically go up. You have to refresh the page. I don't think
this is blocking for now.

> -  In the bookings tab, the calendar shows the booking id (?). This id is
> not displayed in the table, so it's not very clear what it refers to. I
> think it would be better to show the patron's name and cardnumber. Maybe
> with a hover display for short bookings.
> 

I still think it would be better to show something else than the id in the
calendar. Or show the ID in the table so that we can know which is which. 

>
> -  The calendar should show a fixed number of days. Right now it tries to
> adapt to the bookings, but if you have a long one or one in the far future,
> it's all scrunched up https://snipboard.io/5Acelp.jpg I think the next 30
> days is sufficient, and we can scroll as needed.
> 

This was fixed! Thank you!

>
> -  In the bookings tab, in the table, not sure why there is a search box for
> the Actions columns...
> 

The search box is still there. Not a blocker, just weird.

>
> -  I would also like the patron's name to have their cardnumber, and maybe a
> link to their file like in the Holds tab
> 

The link was added! There is still no cardnumber. Not blocking, but it is not
consistent with the rest of Koha.

>
> -  Not sure how I triggered the "It worked" message
> https://snipboard.io/0KNJzp.jpg I think it was by moving a booking around in
> the calendar, but I also got it while scrolling in the calendar (although I
> think the latter was a belated message for the former)
>    If it was for updating a booking, it could say "Booking updated".
> 

Still the case. I don't think this is blocking, but I would like to see more
meaningful messages.

>
> -  Bookings are not shown in the patron file?
> 

This was added! Thank you!

New (?) blocker bugs

-  When I select 'Any item' (https://snipboard.io/X4wGIL.jpg), the booking is
placed for the specific item (https://snipboard.io/zmD3fu.jpg). I thought at
first it was because there was only one item that was bookable on the record,
but I made more items bookable after the booking was made and it stayed on the
specific item. And when I added another booking for 'Any item'
(https://snipboard.io/BPw8iy.jpg) it put it for the same specific item
(https://snipboard.io/w4YBk9.jpg). It also doesn't block the booked dates if I
try to make another booking for 'Any item' (https://snipboard.io/iNVWS4.jpg).
I tried placing a new booking for 'Any item' with the same dates, and it just
added it to the same row (https://snipboard.io/nJhEk0.jpg).

- I noticed in the Bookings tab of the patron file that there are hours to the
start and end dates (https://snipboard.io/P85tHo.jpg). I don't know how I
managed to make a booking from 4 to 3:58... If we permit bookings with hours,
we should be able to choose them when making the booking, and show the hours
everywhere. If not, then displaying only date would be sufficient (and have the
saved date be 00:00 to 23:59?).

- I don't have access to the DB in the sandbox, but I made a report to see what
it looked like. This might be philosophical, but I think we should stick to
borrowernumber, biblionumber and itemnumber as column names. Unless it was
decided otherwise in a dev meeting that now borrowers are patrons and
everything is _id in the DB...

New usability comments

- Would it be possible to add an 'Edit' button? I know we can change the dates
by double-clicking or long-clicking and then sliding the booking sideways in
the calendar view, but I don't find this intuitive. I was trying to slide the
booking and it was sliding the whole calendar (because I hadn't double-clicked
on it first), and I expected double-clicking to open the modal to edit the
booking... Mind you, I might just be weird :) . I wonder if people might also
want to change the item on which the booking is. Mostly everywhere else in Koha
there is an Edit button in the Actions column. 

- In the Bookings tab of the patron file :

  - If possible, could you add links to the bookings tab of the biblio record
under the title (like in the Holds tab).

  - The table says it was filtered from X total entries, which I'm guessing is
the total number of bookings (https://snipboard.io/P85tHo.jpg). I find this
confusing, I'm expecting this patron to have 31 bookings but I somehow filtered
it to show only two.

  - There is also a search box in the Actions column.  

This is it for now! Sorry, I know it's a lot again...

-- 
You are receiving this mail because:
You are watching all bug changes.