[Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

--- Comment #5 from Ray Delahunty <r.delahunty at arts.ac.uk> ---
We are testing auto-renewals in 22.11 (preparing to ditch our auto-renewal
workaround which avoided various bugs like 19014 in place since 17.11). We have
the ‘No renewal before’ set to zero and the renewal script running at 00:15
after the item was late. So far we have found two interesting issues. One is
the renewal handling too soon problem that should be solved if we could have
David Cook’s local customisation. Is the customisation TT code added to the
AUTO_RENEWAL_DGST? I don’t want ‘Visual merchandising’ tacked on as an orphan
on this digest:

There were 1 items that were not renewed.
There were 2 items that were renewed.
Mastering wildlife photography (barcode: 54250053) was not renewed as it is
reserved by another reader.
Cool infographics (barcode 54197511) was renewed until 12/06/2023
The information design handbook (barcode 54240693) was renewed until 12/06/2023
Visual merchandising / : 40620336

The other issue was the digest not dealing well with leavers. We have added one
renewal failure reason missing from the default digest shipped with 22.11: 

[% ELSIF checkout.auto_renew_error == 'auto_account_expired' %] could not be
renewed as your account has expired. 

This new reason should work well with our renewals assessment taking place the
day after the account expiry. But unexpectedly, if I have 2 items due for
renewal assessment tonight and 2 more not due for some days, for leavers, Koha
lumps all 4 items together and tells me all 4 items have failed to renew ([%
error %]=4 not 2), and the two ones that aren’t eligible yet for renewal
assessment are not left tacked onto the end of the renewed / failed renew list
(so, no ‘Visual merchandising’ orphans for leavers). OK, it might seem odd that
items could be due after expiry, but our data feed manipulates the
borrower.dateexpiry and the scenario is (unfortunately) possible. Perhaps the
customisation might fix this and see [% error %] set to two and the digest only
listing the 2 items due now. OK, there would be a second digest for the other
items due later, but that is OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.