[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

--- Comment #25 from Janusz Kaczmarek <januszop at gmail.com> ---
Nick, I have looked into the corrected version. I see one problem: with Zebra,
for:

655 7 $a Literatura angielska $2 DBN

you search first for: "Literatura angielska + DBN" and, since there is no 040
$f, there is the second query for: "Literatura angielska + undefined'

But having two auth records:

00116nz  a2200049n  4500
008 230210 n anznnbabn           a ana     d
155    $a Literatura angielska

00116nz  a2200049n  4500
008 230210 n an|nnbabn           a ana     d
155    $a Literatura angielska

you will get both as response, while only one of them is appropriate (the first
one) [note 008/11].

Why not to index, in Zebra, directly 008/11 and 040 $f into the same index,
without the 'index_subject_thesaurus' help-template which inserts 'undefined'
for lacking 040 $f?

Note that in ES in this case you are adding subject-heading-thesaurus == 'z' to
the query, not '|'.



Also, it is not clear for me why do you hardcoded subject-heading-thesaurus in
Koha/SearchEngine/Elasticsearch.pm, instead of putting it in mapping.yaml as:

  Subject-heading-thesaurus:
    label: Subject-heading-thesaurus
    mappings:
      - facet: ''
        marc_field: 008_/11
        marc_type: marc21
        sort: ~
        suggestible: ''
      - facet: ''
        marc_field: 040f
        marc_type: marc21
        sort: ~
        suggestible: ''
    type: ''

which seems to me more general and therefor natural...

-- 
You are receiving this mail because:
You are watching all bug changes.