[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Oct 14 22:25:55 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |michaela.sieber at kit.edu

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, this is a really interesting feature!

Some notes:

1) The QA test tools are currently still failing, but it's only a perltidy that
is needed.

2) The database update still has the old format and should be moved to the
newer atomic update template.

3) The system preference is added correctly, but should
a) Include a note that this feature is "Elasticsearch only"
b) Be moved to the "Features" section instead of the "Did you mean" where it
appears now.

4) It didn't work in my testing :( Maybe something broke with changes made to
the OPAC since this was submitted the first time?

* I used ktd --es7 up
* Made sure SearchEngine was Elasticsearch and search worked
* Applied patch
* restart_all
* Turned on OPACDisplayRecordCount system preference

I don't see any errors in the console, but the JSON responses come back empty,
possibly because the q param is empty::

http://localhost:8080/cgi-bin/koha/svc/elasticsearch/opac-elasticsearch.pl?q=[]&key=nb_notice
?

I searched for "perl" in a MARC21 sample database and paged through a lot of
the results with no counts showing.

5) Code review
* Please translate code comments if you want to keep them:
+/* Regex pour tous les URL avec un recherche */

This uses the older /svc pattern, we might want to get a second more technical
review on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list