[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
             Status|Signed Off                  |Failed QA

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Fuerste-Henry from comment #7)
> >     1) Go in System preferences and find the "UseBranchTransfertLimits".
> >     2) Change the value of "Don't enforce" to "Enforce".

I honestly need a little help here. 

In the patch we still see the dependency on UseBranchTransferLimits, but the
test plan in the commit message doesn't mention the preference. 

Could you please revise the test plan?

Please also check below and the results I got there:

> I don't understand why the behavior you've coded here only applies when
> UseBranchTransfertLimits is set to Enforce. These two separate dropdowns
> exist regardless of whether or not one is using Branch Transfer Limits. 
> 
> More importantly, this patch breaks existing behavior when I have two items
> on the same bib with different allowed pickup locations. To recreate:
> 
> (apply patch, set UseBranchTransfertLimits to Enforce)
> 1: Set Hold Pickup Library Match in circ rules to "item's hold group"
> 2: Create two library groups, both defined as local holds groups. Give each
> group a couple of libraries, making sure they don't overlap
> 3: Find or create a biblio record with two items. The items should be held
> by different libraries, one in each of your hold groups
> 4: try to place a hold on your bib. on reserve/request.pl, observe that you
> have 3 pickup location dropdown (one for the biblio, one for each item) and
> that all 3 show the same value.

That's not the case in my test. I got:

Library group F: Fairfield, Fairview
Library group C: Centerville, Liberty

Items: Fairfield, Centerville

Pickup location pull downs:

* Record level: All 4
* Item Fairfield: Fairfield, Fairview
* item Centerville: Centerville, Liberty

> 5: confirm that changing the biblio-level dropdown forces the page to reload
> and changes both item dropdowns to match what you selected in the biblio
> dropdown

When I change the record level pick-up location, nothing happens to the item
level ones.

> 6: HOWEVER -- your items each have a distinct set of allowed pickup
> locations. One of your two items will be showing a branch at which it is not
> allowed to be picked up.

Can't replicate this behaviour.

> 7: attempt to place the item-level hold with an illegal pickup location that
> koha has suggested to you. observe that Koha leaves the holds creation page
> without actually making a hold or giving an error message.

Can't replicate this behaviour.

BUT: I see the wrong behaviour if UseBranchTransferLimits is Set to "Don't
enforce". 

* Set prefernece to "Don't enforce"
* Change the biblio record pick-up location from Centerville (logged in
library) to something else and back to Centerville.
* Items do have pickup location Centerville now. But this is not allowed for
the Fairfield item.
* When saved, the hold is not placed.

Then I get the behaviour that invalid pickup locations will get selected for my
items, although they are not actually listed in the pull downs.

This only happens with the patch applied :(

-- 
You are receiving this mail because:
You are watching all bug changes.