[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 24 21:48:28 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410

--- Comment #4 from Blou <philippe.blouin at inlibro.com> ---
I know I might sound blasphemous, but to me C4::Context should not carry this
bagage, even at the cost of the nice OO design.

I want the context.  I think this includes the config file and the sysprefs,
but this should not automatically get the whole schema.  And the only way to do
that would be to access the sysprefs without using Koha::Config::Syspref.  Thus
no Action::Log, no Koha::Object.


I think the structure makes sense OO-wise, but as the great Scott Meyers (shit,
I'm old) said : "Non-member functions improve encapsulation".  In this case,
it's more about pragmatism.  A few old-school SELECT in C4::Context, and you
reduce all your scripts memory footprints by a lot.  

Same with ZOOM?  Does it make sense in C4::Context, in 2023 ?

And Datetime::TimeZone... just to call C4::Context->tz in a few context.  This
could be in DateUtils, asking the context from C4::Context, instead of
C4::Context carrying all that for a few calls.


Maybe I'm naive, but it seems rather simple to reduce 40M of RES out of most
Koha scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list