[Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This works, but there are some bigger and smaller issues:

1) It produces an invalid HTML file, missing the html and body tags. If we were
to add them to the template, the template could no longer be properly displayed
in Koha. That's why I feel it would be better to add those on export. It's
created with a .html ending, so I assume that is the use case.

2) The patch commit line needs to be fixed.

3) I think we should change the label in the download menu to fit with the
others. It's a list of formats now, never including the word "Download", so my
suggestion would be something like: "HTML using [template] '<template>'" 
If possible please avoid the <i> as they break up the string.

4) Perltidy please.

-- 
You are receiving this mail because:
You are watching all bug changes.