[Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #6)
> This works, but there are some bigger and smaller issues:
> 
> 1) It produces an invalid HTML file, missing the html and body tags. If we
> were to add them to the template, the template could no longer be properly
> displayed in Koha. That's why I feel it would be better to add those on
> export. It's created with a .html ending, so I assume that is the use case.

This feature is meant to generate arbitrary formats. The only production use
case we have right now produces an XML file. To make the data viewable before
download I use IF blocks to warp the xml in a textarea. This is just one
possible way to deal with the issue. The main point is that this feature isn't
mean to be HTML only.

> 2) The patch commit line needs to be fixed.

Fixed!

> 3) I think we should change the label in the download menu to fit with the
> others. It's a list of formats now, never including the word "Download", so
> my suggestion would be something like: "HTML using [template] '<template>'" 
> If possible please avoid the <i> as they break up the string.

As explained above, this isn't meant to be strictly for HTML. Instead, I'll
change the option to "Rendered template ( <filename> )". That will more closely
match what we are doing now.

> 
> 4) Perltidy please.

Can do!

-- 
You are receiving this mail because:
You are watching all bug changes.