[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #46 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
I really like where this is going! I found a few more bugs in testing, but it
seems to be nearly there.

The only two that are definite blockers for me are some odd behavior with hold
policy limits:

- When trying to place a hold on an item group, I always got the prompt: "None
of these items can normally be put on hold for this patron. Place hold?"
although there should be nothing forbidding that hold. (with item group holds
enabled and regardless of patron or AllowHoldPolicyOverride value)

- The circ rule for maximum number of items allowed per record was not enforced
for item-level holds. i.e. with a limit of 2, it was possible to place 3
item-level holds for the same patron even if overrides were not allowed. If
overrides are allowed, there should be a warning at the top of the page, but
the warning does not appear for a patron with the max number of item-level
holds.


Not necessarily blockers but would be nice to fix:

- The select2's for pickup location are not actually disabled when the fieldset
is disabled. (They are greyed out, and the data selected is not used, but
they're still clickable.) Is this an oversight, or is it an unfortunate
characteristic of select2's? (not necessarily a blocker for me because the
visual cue and actual processing of data are correct)

- When enforcing that a patron with an existing item-level hold may only place
item-level holds, the heading for item-level holds says (Required) in bright
red. Same thing for item group holds. However, the heading for record-level
holds does not say (Required). (this is the case in master, but if it's easy to
add in here for consistency, I'd say do it)

-- 
You are receiving this mail because:
You are watching all bug changes.