[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
This does fix the issue, and I have signed off.

However, some comments - not sure how hard these are to do or whether it
depends on the ILL plugin (I'm assuming this is the case):

1. If the "Destination library" is not selected, then the message at the top
says: "Please Note: Branch is a mandatory field.". In my view the error should
match the UI, that is, instead of "Branch" it should say "Destination library
is required"

2. The normal UI for forms in the OPAC (from what I can see) is to have
"Required" under the field name, and then a message if mandatory fields are not
completed. I assume that this depends on how the ILL plugin works/coded though.

Testing notes (using KTD):

1. Make the ILL request using the OPAC!
   . Go to the OPAC
   . Log in as a patron
   . Make the request using the "Interlibrary loan requests" tab/section

-- 
You are receiving this mail because:
You are watching all bug changes.