[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685

--- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to David Nind from comment #3)
> This does fix the issue, and I have signed off.
> 
> However, some comments - not sure how hard these are to do or whether it
> depends on the ILL plugin (I'm assuming this is the case):
> 
> 1. If the "Destination library" is not selected, then the message at the top
> says: "Please Note: Branch is a mandatory field.". In my view the error
> should match the UI, that is, instead of "Branch" it should say "Destination
> library is required"
> 
> 2. The normal UI for forms in the OPAC (from what I can see) is to have
> "Required" under the field name, and then a message if mandatory fields are
> not completed. I assume that this depends on how the ILL plugin works/coded
> though.

Hi David, thanks for testing!
Your assumptions are correct. The form and its behavior is dependent on the
specific ILL backend which the request is being created to, in this example
it's FreeForm. 

In bug 35570 I'm submitting work to add FreeForm to Koha core, to become a
backend available out of the box instead of it being required to install an
external one in order to make use of the ILL module.
I mention bug 35570 because once that's gone through, these sort of
enhancements can be worked directly into Koha, and have at least the Koha
native backend be consistent with everything else.

-- 
You are receiving this mail because:
You are watching all bug changes.