https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35700 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- I have some questions: 1. - [ -date <YYYY-MM-DD> ] Why? 2. + my $today = $date_to_run; [...] + next if $calendar->is_holiday($today); [...] + $waiting_date = $calendar->addDays( $date_to_run, $duration ); #Add negative of days Why are you using a new "today" variable? Also note that $today is not today's date and I think is misleading (and it's why we named it date_to_run) 3. Shouldn't we actually use Koha::Calendar::next_open_days here? -- You are receiving this mail because: You are watching all bug changes.