https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #91 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Thanks Martin. Rebased on current main and addressed (folded into "Align POST /checkins with the bug 42383 endpoint design"): 1. Items without a barcode are rejected before AddReturn: 409 item_without_barcode. Tested. 2. library_id defaults to the logged in library (session or x-koha-library), as GET /checkins/availability and the legacy page do. Unknown libraries get 400 invalid_parameter_value, on both endpoints. Scope follows the rule already applied to the x-koha-library header (Koha::Patron->can_log_into): with IndependentBranches, only superlibrarians can act on another library (403 library_not_allowed). Tested. 3. A check-in of an item that was not checked out is recorded with a null checkout_id: this is now documented in the spec. 4. The spec now says that the 412 confirmation is a workflow gate, not an authorization control. Token purpose binding (typ/aud) affects every Koha::Token caller, so it is filed as bug 44080. 5. An unparseable return_date gives 400 invalid_parameter_value instead of a 500. 6. to_library: the legacy page did not check transfer limits on check-in either, AddReturn handles the transfer to the return library. No change. 7. A test now embeds debits on a check-in that charges an overdue fine, and checks the debit points back to the check-in. 8. Tests added: token used by another user, tampered token, return_date (valid and unparseable), dropbox_mode, barcode-less item, unknown library_id, IndependentBranches scope. Expired tokens are covered in t/Koha/Token.t and t/Koha/Result/Availability.t. The endpoints are marked EXPERIMENTAL in the spec ("EXPERIMENTAL - DO NOT RELY on this, it is subject to change!"), as we did for the Vue app endpoints of ERM, ILL and Preservation: they serve the new check-in page and may still change. Back to Signed Off. -- You are receiving this mail because: You are watching all bug changes.